Uh oh!
There was an error while loading. Please reload this page.
python: reject non-contiguous buffers - #655
Open
mraimadeddinehouas-glitch wants to merge 1 commit into
Open
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mraimadeddinehouas-glitchforce-pushed
the
python-buffer-validation-fix
branch
2 times, most recently
from
August 28, 2026 02:17
1b1bcd3 to
641edd9Comparemraimadeddinehouas-glitchforce-pushed
the
python-buffer-validation-fix
branch
from
August 28, 2026 02:22
641edd9 to
b8a3180Comparemraimadeddinehouas-glitch
commented
Aug 29, 2026
Author
Hello RE2 maintainers — when convenient, could you please review this PR? The patch is narrowly scoped to the Python binding, the C++ and Python test suites pass, the Google CLA check passes, and the commit is verified. The PR is ready for review; thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python binding requests a full buffer view but previously treated every buffer as a contiguous one-dimensional byte string. This is unsafe for non-contiguous, multi-dimensional, or wider-item buffers: the pointer arithmetic and byte length do not describe the logical view.
This change validates the buffer layout before constructing an absl::string_view. Unsupported layouts are rejected unless the buffer is one-dimensional, byte-sized, and has a unit stride.
A regression test covers reversed and strided memoryviews for both pattern and input paths.
Validation: