Uh oh!
There was an error while loading. Please reload this page.
build: sync Bazel CXX warning flags with CMake - #610
Open
abhinavgautam01 wants to merge 2 commits into
Open
Conversation
jmr
reviewed
May 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
Add the same -Wno-* and -fsized-deallocation flags used in CMakeLists for non-MSVC toolchains; cross-reference in CMake comment.
abhinavgautam01force-pushed
the
issue-458-bazel-warnings-sync
branch
from
May 10, 2026 19:17
5942c13 to
ff47278Comparejmr
reviewed
May 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
jmr
requested changes
May 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
abhinavgautam01
commented
May 13, 2026
ContributorAuthor
ping @jmr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#458
Add the same non-MSVC C++ compile options already applied in CMake to Bazel via
src/.bazelrc(-Wno-attributes,-Wno-deprecated-declarations,-Wno-nullability-completeness,-Wno-psabi,-fsized-deallocation), with a short note in CMakeLists to keep the two in sync. MSVC /clBazel builds are not in CI here; maintainers on Windows can override via a local/user config if needed.