Skip to content

gtest should be found while build with testing #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ClausKlein wants to merge 4 commits into from
Closed

gtest should be found while build with testing #66

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0170a45
gtest should be found if while testing
ClausKlein Mar 11, 2018
b3ee613
CMakeLists.txt requires Gtest while testing
ClausKlein Mar 11, 2018
45a51af
seems that testing is not so important?
ClausKlein Mar 11, 2018
c8c5ec9
enable ctest again
ClausKlein Mar 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,17 @@ check_include_file("unistd.h" HAVE_UNISTD_H)
check_include_file("windows.h" HAVE_WINDOWS_H)

include(CheckLibraryExists)
check_library_exists(z zlibVersion "" HAVE_LIBZ)
check_library_exists(lzo2 lzo1x_1_15_compress "" HAVE_LIBLZO2)
if(UNIX)
link_directories(/opt/local/lib /usr/local/lib)
find_package(Zlib)
if(Zlib_FOUND)
set(HAVE_LIBZ ON)
endif(Zlib_FOUND)
check_library_exists(lzo2 lzo1x_1_15_compress "/opt/local/lib" HAVE_LIBLZO2)
else(UNIX)
check_library_exists(z zlibVersion "" HAVE_LIBZ)
check_library_exists(lzo2 lzo1x_1_15_compress "" HAVE_LIBLZO2)
endif(UNIX)

include(CheckCXXSourceCompiles)
check_cxx_source_compiles(
Expand All @@ -37,15 +46,10 @@ include(CheckSymbolExists)
check_symbol_exists("mmap" "sys/mman.h" HAVE_FUNC_MMAP)
check_symbol_exists("sysconf" "unistd.h" HAVE_FUNC_SYSCONF)

find_package(GTest QUIET)
if(GTEST_FOUND)
set(HAVE_GTEST 1)
endif(GTEST_FOUND)

find_package(Gflags QUIET)
if(GFLAGS_FOUND)
set(HAVE_GFLAGS 1)
endif(GFLAGS_FOUND)
# set debug postfix a la boost
set(CMAKE_DEBUG_POSTFIX "-d")


configure_file(
"${PROJECT_SOURCE_DIR}/cmake/config.h.in"
Expand Down Expand Up @@ -109,6 +113,10 @@ if(BUILD_SHARED_LIBS)
endif(BUILD_SHARED_LIBS)

if(SNAPPY_BUILD_TESTS)
find_package(GTest REQUIRED)
find_package(Gflags)
##TBD find_package(Threads)

enable_testing()

add_executable(snappy_unittest "")
Expand All @@ -118,7 +126,8 @@ if(SNAPPY_BUILD_TESTS)
"${PROJECT_SOURCE_DIR}/snappy-test.cc"
)
target_compile_definitions(snappy_unittest PRIVATE -DHAVE_CONFIG_H)
target_link_libraries(snappy_unittest snappy ${GFLAGS_LIBRARIES})
target_link_libraries(snappy_unittest snappy ${GFLAGS_LIBRARIES} ${GTEST_LIBRARIES})
##TBD target_link_libraries(snappy_unittest snappy ${THREADS_LIBRARIES})

if(HAVE_LIBZ)
target_link_libraries(snappy_unittest z)
Expand Down