Uh oh!
There was an error while loading. Please reload this page.
Handle file upload request - #52
Open
wanlin31 wants to merge 1 commit into
Open
Conversation
wanlin31force-pushed
the
files
branch
2 times, most recently
from
September 16, 2025 17:09
682d5ad to
cbb76a5Comparewanlin31
commented
Sep 16, 2025
| @@ -112,8 +112,16 @@ func readBody(req *http.Request) (map[string]any, error) { | |||
| } | |||
| err = json.Unmarshal(body, &resultMap) | |||
| if err != nil { | |||
CollaboratorAuthor
There was a problem hiding this comment.
When the data can't be json.unmarshal, they can be the byte data from file upload. We let the byte data fall through to req.body without changing it.
wanlin31
commented
Sep 16, 2025
| @@ -0,0 +1,56 @@ | |||
| { | |||
CollaboratorAuthor
There was a problem hiding this comment.
This new file is part of the file upload, there was issue inside the genai python file upload, the headers are not passing through, have an internal fix for that.
wanlin31
marked this pull request as ready for review
September 16, 2025 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the byte data fall through to req.body without changing it.
This is needed for file.upload. Added a test to demonstrate.