Skip to content

Add NTP tests - #60

Merged
jboddey merged 7 commits into
devfrom
ntp
Jul 12, 2023
Merged

Add NTP tests#60
jboddey merged 7 commits into
devfrom
ntp

Conversation

@jboddey

@jboddeyjboddey commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

Adds 2x NTP tests:

  • ntp.network.ntp_support
  • ntp.network.ntp_dhcp

@jboddeyjboddey added the test A new test case or issue identified with a test label Jun 30, 2023
@jboddeyjboddey added this to the Sprint 9 milestone Jun 30, 2023
@jboddey
jboddey requested a review from JoannaBakoJune 30, 2023 16:29
@jboddeyjboddey self-assigned this Jun 30, 2023
@jboddey

jboddey commented Jun 30, 2023

Copy link
Copy Markdown
ContributorAuthor

@JoannaBako could you try these 2x tests against some physical devices? I do not have a device to hand with NTPv4 or one that uses a DHCP provided NTP server.

@jboddey
jboddey requested review from jhughesoti and removed request for JoannaBakoJuly 4, 2023 09:09
jhughesoti
jhughesoti reviewed Jul 7, 2023
View reviewed changes

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a device that supports NTPv4 and option 42 and got passing results as expected. Don't have a way to confirm failing results though.

Comment threadmodules/test/ntp/conf/module_config.json Outdated
Comment threadmodules/test/ntp/python/src/ntp_module.py
@jboddey

ghost commented Jul 7, 2023

Copy link
Copy Markdown
ContributorAuthor

@jhughesbiot Could you take a look at the pylint of the current dev branch? Not sure what's happened, seems the pylint score has increased on the dhcp branch maybe but it already merged.

@jhughesoti

ghost commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

@jboddey I just added a PR into this branch that deals with a lot of the pylint issues from the recent dhcp work. There are a fair amount of others introduced into the framework but don't want to muddy the waters further until we get this in.
#69

@jboddey
jboddey merged commit 9ef0d4f into devJul 12, 2023
@jboddey
jboddey deleted the ntp branch July 12, 2023 08:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jhughesotijhughesotijhughesoti left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@jboddeyjboddey

Labels

testA new test case or issue identified with a test

Projects

None yet

Milestone

Sprint 9

Development

Successfully merging this pull request may close these issues.

2 participants

@jboddey@jhughesoti