Fix Bazel support to compile C++ library - #23
Merged
Conversation
carlonzo
commented
Jun 1, 2023
|
|
||
| load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository") | ||
|
|
||
| git_repository( |
Contributor
Author
There was a problem hiding this comment.
anayw2001
reviewed
Jun 8, 2023
| name = "boringssl", | ||
| branch = "master-with-bazel", | ||
| remote = "https://boringssl.googlesource.com/boringssl", | ||
| ) No newline at end of file |
Collaborator
There was a problem hiding this comment.
could you add a newline at the end of this file?
Contributor
Author
There was a problem hiding this comment.
I'm sorry I missed this somehow. I'll open another PR. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had issues to compile the C++ library using Bazel:
Sending this PR to open a discussion if my configuration is correct. I've seen the bazel migration was done quite recently