Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Sep 27, 2023. It is now read-only.
add transformAsync and bump version to 1.0.1 - #28
Merged
Conversation
pongad
commented
May 10, 2017
| } | ||
| public static <I, O> ApiFuture<O> transformAsync( | ||
| ApiFuture<I> input, final ApiAsyncFunction<I, O> function) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #28 +/- ##
============================================
+ Coverage 56.61% 58.72% +2.11% - Complexity 126 133 +7
============================================
Files 15 15 Lines 590 596 +6 Branches 91 91 ============================================
+ Hits 334 350 +16 + Misses 233 224 -9 + Partials 23 22 -1
Continue to review full report at Codecov.
|
| @@ -1 +1 @@ | |||
| 1.0.0 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
michaelbausor
left a comment
Contributor
There was a problem hiding this comment.
LGTM after version change
| * | ||
| * <p>It is similar to Guava's {@code AsyncFunction}, redeclared so that Guava can be shaded. | ||
| */ | ||
| public interface ApiAsyncFunction<F, T> { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
garrettjonesgoogle
commented
May 10, 2017
Contributor
LGTM after you update the commit description. |
pongad added a commit
to googleapis/google-cloud-java
that referenced
this pull request
May 11, 2017
This brings in the change in googleapis/api-common-java#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.