Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

chore: refactor wrap method helper into a macro - #2111

Merged
ohmayr merged 6 commits into
mainfrom
refactor-wrap-method-macro
Aug 30, 2024
Merged

chore: refactor wrap method helper into a macro#2111
ohmayr merged 6 commits into
mainfrom
refactor-wrap-method-macro

Conversation

@ohmayr

@ohmayrohmayr commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

This PR does the following:

  • adds a kind property to async gRPC transport similar to sync gRPC.
  • implements a macro to call _prep_wrapped_messages; can be re-used for async REST.
  • implements a macro to add a helper for conditionally calling wrap_method with the kind property configured.

@ohmayr
ohmayr requested a review from a teamAugust 28, 2024 18:38
@product-auto-labelproduct-auto-labelBot added the size: l Pull request size is large. label Aug 28, 2024
@ohmayr
ohmayrforce-pushed the refactor-wrap-method-macro branch from cae7e99 to 94a46f4CompareAugust 28, 2024 18:38
@ohmayr
ohmayrforce-pushed the refactor-wrap-method-macro branch from 8c77cc0 to af98897CompareAugust 28, 2024 19:33
vchudnov-g
vchudnov-g suggested changes Aug 29, 2024
View reviewed changes
Comment thread...ration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc_asyncio.py Outdated
Comment threadgapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2
vchudnov-g
vchudnov-g reviewed Aug 29, 2024
View reviewed changes
Comment thread...ration/goldens/asset/google/cloud/asset_v1/services/asset_service/transports/grpc_asyncio.py Outdated
Comment threadgapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/_shared_macros.j2 Outdated
vchudnov-g
vchudnov-g approved these changes Aug 29, 2024
View reviewed changes

@vchudnov-gvchudnov-g left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, please address the comments here about enforcing macro contracts, but otherwise LGTM now. Thanks for working on this and answering my questions!

@ohmayr

ohmayr commented Aug 29, 2024

Copy link
Copy Markdown
ContributorAuthor

OK, please address the comments here about enforcing macro contracts, but otherwise LGTM now. Thanks for working on this and answering my questions!

I've updated the contract and will shortly be merging this. Thanks for the feedback!

@ohmayrohmayr changed the title chore: refactor wrapping method helper into a macrochore: refactor wrapping wrap helper into a macroAug 30, 2024
@ohmayrohmayr changed the title chore: refactor wrapping wrap helper into a macrochore: refactor wrap method helper into a macroAug 30, 2024
@ohmayr
ohmayr merged commit 1967aa1 into mainAug 30, 2024
@ohmayr
ohmayr deleted the refactor-wrap-method-macro branch August 30, 2024 04:13
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@partheapartheaparthea approved these changes
@vchudnov-gvchudnov-gvchudnov-g approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@partheaparthea

@vchudnov-gvchudnov-g

Labels

size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ohmayr@parthea@vchudnov-g