Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

test: add routing parameter and empty call test for REST - #2165

Merged
parthea merged 11 commits into
mainfrom
refactor-routing-parameters-test-rest
Oct 9, 2024
Merged

test: add routing parameter and empty call test for REST#2165
parthea merged 11 commits into
mainfrom
refactor-routing-parameters-test-rest

Conversation

@parthea

@partheaparthea commented Sep 16, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds routing parameter tests for REST transport

This PR depends on #2133 and #2131. Please review those PRs first.

Fixes#2159
Closes b/364925979

@product-auto-labelproduct-auto-labelBot added the size: xl Pull request size is extra large. label Sep 16, 2024
@partheaparthea changed the title test: add routing parameter test for RESTtest: add routing parameter and empty call test for RESTSep 16, 2024
Base automatically changed from refactor-routing-parameters-test to mainSeptember 18, 2024 16:21
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Oct 9, 2024
@parthea
partheaforce-pushed the refactor-routing-parameters-test-rest branch from 4189ada to 8e3f9deCompareOctober 9, 2024 16:38
@parthea
parthea marked this pull request as ready for review October 9, 2024 16:38
@parthea
parthea requested a review from a teamOctober 9, 2024 16:38
@partheaparthea closed this Oct 9, 2024
@parthea
parthea deleted the refactor-routing-parameters-test-rest branch October 9, 2024 16:39
@parthea
parthea restored the refactor-routing-parameters-test-rest branch October 9, 2024 16:40
@partheaparthea reopened this Oct 9, 2024
@parthea
partheaforce-pushed the refactor-routing-parameters-test-rest branch from 8e3f9de to 6a128b5CompareOctober 9, 2024 16:43
@product-auto-labelproduct-auto-labelBot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Oct 9, 2024
ohmayr
ohmayr reviewed Oct 9, 2024
View reviewed changes
Comment threadgapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated
ohmayr
ohmayr reviewed Oct 9, 2024
View reviewed changes
Comment threadgapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated
ohmayr
ohmayr reviewed Oct 9, 2024
View reviewed changes
Comment threadgapic/templates/tests/unit/gapic/%name_%version/%sub/test_macros.j2 Outdated
@ohmayr

ohmayr commented Oct 9, 2024

Copy link
Copy Markdown
Contributor

We may want to clean this up: https://github.com/googleapis/gapic-generator-python/pull/2165/files#diff-0f64a5dcd8e2f3ac9b10417f899604726f8111968a1b5e46b6339c39df071af0R2813-R2815.

@parthea
parthea enabled auto-merge (squash) October 9, 2024 18:12
@parthea
parthea merged commit da684d5 into mainOct 9, 2024
@parthea
parthea deleted the refactor-routing-parameters-test-rest branch October 9, 2024 18:19
gkevinzheng pushed a commit that referenced this pull request Oct 22, 2024
@parthea@gkevinzheng
test: add routing parameter and empty call test for REST (#2165)
b30ee6a
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ohmayrohmayrohmayr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vchudnov-gvchudnov-g

Labels

size: xlPull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the empty_call_test and routing_parameter_test macro so that it can be used for both gRPC and REST

3 participants

@parthea@ohmayr@vchudnov-g