Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

add mTLS support to generator - #359

Merged
software-dov merged 11 commits into
masterfrom
sijun/mtls
Apr 8, 2020
Merged

add mTLS support to generator#359
software-dov merged 11 commits into
masterfrom
sijun/mtls

Conversation

@arithmetic1728

@arithmetic1728arithmetic1728 commented Apr 3, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

For #360

Currently python-api-core doesn't have client_cert_source in ClientOptions, so the code in this PR uses the unreleased python-api-core code in this branch:
https://github.com/googleapis/python-api-core/tree/sijun/cert

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2020
software-dov
software-dov reviewed Apr 6, 2020
View reviewed changes

@software-dovsoftware-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, especially the generated unit tests. Just a few minor issues.

Comment threadnoxfile.py
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2 Outdated
Comment threadgapic/templates/tests/unit/%name_%version/%sub/test_%service.py.j2 Outdated
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
software-dov
software-dov reviewed Apr 7, 2020
View reviewed changes

@software-dovsoftware-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits.

Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2 Outdated
Comment threadgapic/templates/tests/unit/%name_%version/%sub/test_%service.py.j2 Outdated
Comment threadgapic/templates/tests/unit/%name_%version/%sub/test_%service.py.j2 Outdated
Comment threadgapic/templates/tests/unit/%name_%version/%sub/test_%service.py.j2 Outdated
Comment threadgapic/templates/tests/unit/%name_%version/%sub/test_%service.py.j2
Comment threadgapic/templates/%namespace/%name_%version/%sub/services/%service/transports/grpc.py.j2 Outdated
software-dov
software-dov approved these changes Apr 8, 2020
View reviewed changes

@software-dovsoftware-dov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you file an issue to track adding mTLS support to the ads templates?

@software-dov
software-dov merged commit a354629 into masterApr 8, 2020
@software-dov
software-dov deleted the sijun/mtls branch April 8, 2020 21:54
@arithmetic1728
arithmetic1728 restored the sijun/mtls branch April 8, 2020 22:34
arithmetic1728 added a commit that referenced this pull request Apr 8, 2020
@arithmetic1728
Revert "Add mTLS support to generator (#359)"
a53b7cf
This reverts commit a354629.
@arithmetic1728arithmetic1728 mentioned this pull request Apr 8, 2020
Closed
@arithmetic1728
arithmetic1728 deleted the sijun/mtls branch April 9, 2020 21:01
@arithmetic1728arithmetic1728 mentioned this pull request Apr 9, 2020
Merged
@lidizhenglidizheng mentioned this pull request Apr 14, 2020
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@software-dovsoftware-dovsoftware-dov approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arithmetic1728@software-dov@googlebot