Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

chore: distinguish default/mtls endpoint for tests - #551

Merged
arithmetic1728 merged 3 commits into
masterfrom
sijun
Jul 23, 2020
Merged

chore: distinguish default/mtls endpoint for tests#551
arithmetic1728 merged 3 commits into
masterfrom
sijun

Conversation

@arithmetic1728

@arithmetic1728arithmetic1728 commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

showcase has default endpoint localhost:7469, so mtls endpoint is the same. When we interchange client.DEFAULT_ENDPOINT and client.DEFAULT_MTLS_ENDPOINT by mistake, the unit tests still pass. This causes problem, because generated client lib always has *.googleapis.com as the default endpoint, so mtls endpoint is always different (*.mtls.googleapis.com), so client lib unit test always fail. This PR replaces the default endpoint in case it is localhost (as it does in showcase unit tests) so we can distinguish the endpoints in showcase unit test.

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2020
@codecov

codecovBot commented Jul 23, 2020

Copy link
Copy Markdown

Codecov Report

Merging #551 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #551 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 26 26 Lines 1477 1508 +31 Branches 308 308 =========================================
+ Hits 1477 1508 +31 
Impacted FilesCoverage Δ
gapic/schema/api.py100.00% <0.00%> (ø)
gapic/schema/imp.py100.00% <0.00%> (ø)
gapic/utils/cache.py100.00% <0.00%> (ø)
gapic/schema/metadata.py100.00% <0.00%> (ø)
gapic/schema/wrappers.py100.00% <0.00%> (ø)
gapic/generator/options.py100.00% <0.00%> (ø)
gapic/samplegen/samplegen.py100.00% <0.00%> (ø)
gapic/samplegen_utils/types.py100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a7062...4a36e0e. Read the comment docs.

@arithmetic1728
arithmetic1728 merged commit d80e109 into masterJul 23, 2020
@arithmetic1728
arithmetic1728 deleted the sijun branch July 23, 2020 20:40
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@arithmetic1728@software-dov