Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: remove support for google-api-core<1.26.0 - #893

Merged
busunkim96 merged 2 commits into
masterfrom
remove-old-api-core-path
May 19, 2021
Merged

fix: remove support for google-api-core<1.26.0#893
busunkim96 merged 2 commits into
masterfrom
remove-old-api-core-path

Conversation

@busunkim96

@busunkim96busunkim96 commented May 19, 2021

Copy link
Copy Markdown
Contributor

Drop support for google-api-core < 1.26.0. This code was originally added in #774.

This should unblock the coverage failures in the generated showcase unit tests for #888.

@busunkim96
busunkim96 requested a review from a teamMay 19, 2021 20:18
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label May 19, 2021
@codecov

codecovBot commented May 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #893 (738ca21) into master (7c185e8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## master #893 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 26 27 +1 Lines 1608 1697 +89 Branches 328 347 +19 =========================================
+ Hits 1608 1697 +89 
Impacted FilesCoverage Δ
gapic/samplegen_utils/types.py100.00% <ø> (ø)
gapic/samplegen_utils/utils.py100.00% <ø> (ø)
gapic/utils/case.py100.00% <ø> (ø)
gapic/utils/reserved_names.py100.00% <ø> (ø)
gapic/generator/generator.py100.00% <100.00%> (ø)
gapic/samplegen/samplegen.py100.00% <100.00%> (ø)
gapic/schema/api.py100.00% <100.00%> (ø)
gapic/schema/metadata.py100.00% <100.00%> (ø)
gapic/schema/wrappers.py100.00% <100.00%> (ø)
gapic/utils/__init__.py100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2afba5a...738ca21. Read the comment docs.

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to be able to drop support for the older google-auth versions, too.

@busunkim96

Copy link
Copy Markdown
ContributorAuthor

@tseaver Definitely! I'm planning on a cutting a release for google-api-core that requires a newer google-auth version.

@busunkim96
busunkim96 merged commit ce558ac into masterMay 19, 2021
@busunkim96
busunkim96 deleted the remove-old-api-core-path branch May 19, 2021 21:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@busunkim96@tseaver