Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
add SettableRpcFuture - #205
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #205 +/- ##
============================================
+ Coverage 69.72% 69.93% +0.21% - Complexity 464 475 +11
============================================
Files 65 66 +1 Lines 2454 2478 +24 Branches 262 262 ============================================
+ Hits 1711 1733 +22 - Misses 646 648 +2
Partials 97 97
Continue to review full report at Codecov.
|
garrettjonesgoogle
commented
Feb 15, 2017
Contributor
Are tests worth it? |
pongad
commented
Feb 16, 2017
ContributorAuthor
@garrettjonesgoogle Not sure if this is an overkill or not. PTAL. |
garrettjonesgoogle
commented
Feb 16, 2017
Contributor
LGTM |
pongad added a commit
that referenced
this pull request
Feb 16, 2017
This should be merged after #205 so that `SettableRpcFuture` could be used to address googleapis/google-cloud-java#1613
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.