Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Add randomized flag in RetrySettings, improve documentation. - #356

Merged
vam-google merged 5 commits into
googleapis:masterfrom
vam-google:master
Aug 23, 2017
Merged

Add randomized flag in RetrySettings, improve documentation.#356
vam-google merged 5 commits into
googleapis:masterfrom
vam-google:master

Conversation

@vam-google

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Aug 23, 2017

Copy link
Copy Markdown

Codecov Report

Merging #356 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@ Coverage Diff @@## master #356 +/- ##
============================================
- Coverage 76.65% 76.63% -0.03% - Complexity 494 495 +1 
============================================
Files 114 114 Lines 2540 2542 +2 Branches 185 185 ============================================
+ Hits 1947 1948 +1 
Misses 522 522 - Partials 71 72 +1
Impacted FilesCoverage ΔComplexity Δ
...le/api/gax/retrying/ExponentialRetryAlgorithm.java94.11% <50%> (+0.17%)8 <1> (+1)⬆️
...ava/com/google/api/gax/retrying/RetrySettings.java32.65% <75%> (-0.69%)3 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac1b74...f95f9cc. Read the comment docs.

* The MaxAttempts defines the maximum number of attempts to perform. The default value is 0. If
* this value is greater than 0, and the number of attempts reaches this limit, the logic will
* give up retrying even if the total retry time is still lower than TotalTimeout. The default
* value is {@code 0}.

This comment was marked as spam.

* MaxAttempts defines the maximum number of attempts to perform. If number of attempts reaches
* this limit the logic will give up retrying even if the total retry time is still lower than
* TotalTimeout.
* The MaxAttempts defines the maximum number of attempts to perform. If number of attempts

This comment was marked as spam.

* as an upper bound of the randomized value, which in its turn will be used as an actually
* applied delay time. The default value is {@code true}.
*/
public abstract Builder setRandomized(boolean randomized);

This comment was marked as spam.

This comment was marked as spam.

@vam-google

Copy link
Copy Markdown
ContributorAuthor

PTAL

@vam-google

Copy link
Copy Markdown
ContributorAuthor

PTAL

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google
vam-google merged commit f8acadd into googleapis:masterAug 23, 2017
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vam-google@codecov-io@garrettjonesgoogle