Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Split off ServerStreamingCallableTests into own files - #435

Merged
garrettjonesgoogle merged 1 commit into
googleapis:masterfrom
igorbernstein2:ssc-1-test-split
Nov 30, 2017
Merged

Split off ServerStreamingCallableTests into own files#435
garrettjonesgoogle merged 1 commit into
googleapis:masterfrom
igorbernstein2:ssc-1-test-split

Conversation

@igorbernstein2

@igorbernstein2igorbernstein2 commented Nov 29, 2017

Copy link
Copy Markdown
Contributor

Nonfunctional change in preparation for #433.

Simply moves server streaming tests into their own files to cut down on the noise in the next PR

@codecov-io

codecov-io commented Nov 29, 2017

Copy link
Copy Markdown

Codecov Report

Merging #435 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #435 +/- ##
=========================================
Coverage 70.53% 70.53% Complexity 634 634 =========================================
Files 136 136 Lines 2912 2912 Branches 220 220 =========================================
Hits 2054 2054 Misses 776 776 Partials 82 82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b86a50...d458192. Read the comment docs.

garrettjonesgoogle
garrettjonesgoogle reviewed Nov 30, 2017
View reviewed changes
Comment threadgax/src/test/java/com/google/api/gax/rpc/ServerStreamingCallableTest.java
.build();
}

private static class AccumulatingStreamObserver implements ApiStreamObserver<Integer> {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle
garrettjonesgoogle approved these changes Nov 30, 2017
View reviewed changes

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettjonesgoogle
garrettjonesgoogle merged commit 459a80a into googleapis:masterNov 30, 2017
@igorbernstein2
igorbernstein2 deleted the ssc-1-test-split branch January 10, 2018 05:21
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@garrettjonesgooglegarrettjonesgooglegarrettjonesgoogle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2@codecov-io@garrettjonesgoogle