Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Expose retryableCodes on ServerStreamingCallables. - #461

Merged
garrettjonesgoogle merged 2 commits into
googleapis:masterfrom
igorbernstein2:ssc-7a-retries-part1
Jan 30, 2018
Merged

Expose retryableCodes on ServerStreamingCallables.#461
garrettjonesgoogle merged 2 commits into
googleapis:masterfrom
igorbernstein2:ssc-7a-retries-part1

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

This allows configuration of the ApiException callable on in ServerStreamingCallable chain.
Eventually this will be paired with RetrySettings and a RetryingServerStreamingCallable to
provide retries for streaming rpcs. For now, it unblocks the development of a retry solution
outside of the gax repo.

This is necessary to unblock development of the bigtable client, while I work on integrating #449.

This allows configuration of the ApiException callable on in ServerStreamingCallable chain.
Eventually this will be paired with RetrySettings and a RetryingServerStreamingCallable to
provide retries for streaming rpcs. For now, it unblocks the development of a retry solution
outside of the gax repo.
@codecov-io

codecov-io commented Jan 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #461 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #461 +/- ##
============================================
+ Coverage 71.2% 71.57% +0.37% - Complexity 726 731 +5 
============================================
Files 154 154 Lines 3233 3244 +11 Branches 240 240 ============================================
+ Hits 2302 2322 +20 + Misses 837 829 -8 + Partials 94 93 -1
Impacted FilesCoverage ΔComplexity Δ
...a/com/google/api/gax/grpc/GrpcCallableFactory.java69.23% <100%> (ø)8 <0> (ø)⬇️
...oogle/api/gax/rpc/ServerStreamingCallSettings.java100% <100%> (+100%)4 <2> (+4)⬆️
.../java/com/google/api/gax/grpc/GrpcCallContext.java72.46% <0%> (+1.44%)22% <0%> (+1%)⬆️
.../com/google/api/gax/rpc/StreamingCallSettings.java83.33% <0%> (+16.66%)2% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a77fc...34b2a9e. Read the comment docs.

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@igorbernstein2

Copy link
Copy Markdown
ContributorAuthor

done

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettjonesgoogle
garrettjonesgoogle merged commit e5ef54d into googleapis:masterJan 30, 2018
@igorbernstein2
igorbernstein2 deleted the ssc-7a-retries-part1 branch November 22, 2021 19:42
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2@codecov-io@garrettjonesgoogle