Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Remove paged response wrappers in LRO - #471

Merged
andreamlin merged 6 commits into
googleapis:masterfrom
andreamlin:remove_paged_response_wrappers_LRO
Mar 7, 2018
Merged

Remove paged response wrappers in LRO#471
andreamlin merged 6 commits into
googleapis:masterfrom
andreamlin:remove_paged_response_wrappers_LRO

Conversation

@andreamlin

Copy link
Copy Markdown
Contributor

Created from toolkit PR googleapis/gapic-generator#1833.

private final OperationsSettings settings;
private final OperationsStub stub;

public static class ListOperationsPagedResponse

This comment was marked as spam.

This comment was marked as spam.

@codecov-io

codecov-io commented Feb 1, 2018

Copy link
Copy Markdown

Codecov Report

Merging #471 into master will increase coverage by 0.04%.
The diff coverage is 93.75%.

Impacted file tree graph

@@ Coverage Diff @@## master #471 +/- ##
============================================
+ Coverage 71.01% 71.06% +0.04% 
Complexity 743 743 ============================================
Files 156 155 -1 Lines 3340 3338 -2 Branches 240 240 ============================================
Hits 2372 2372 + Misses 875 873 -2 
Partials 93 93
Impacted FilesCoverage ΔComplexity Δ
...oogle/longrunning/stub/OperationsStubSettings.java73.83% <ø> (ø)8 <0> (ø)⬇️
...om/google/longrunning/stub/GrpcOperationsStub.java91.46% <ø> (ø)10 <0> (ø)⬇️
...va/com/google/longrunning/stub/OperationsStub.java16.66% <ø> (ø)1 <0> (ø)⬇️
...ava/com/google/longrunning/OperationsSettings.java29.03% <ø> (ø)2 <0> (ø)⬇️
.../java/com/google/longrunning/OperationsClient.java72.88% <93.75%> (+7.76%)16 <0> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3030ca8...854f083. Read the comment docs.

@andreamlin

Copy link
Copy Markdown
ContributorAuthor

PTAL

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongadpongad mentioned this pull request Feb 2, 2018

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please merge

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

(after fixing the headers...)

@andreamlin

Copy link
Copy Markdown
ContributorAuthor

What's up with the headers?

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

The headers are taken care of with the merge from master - go ahead and merge.

@andreamlin
andreamlin merged commit b4eae66 into googleapis:masterMar 7, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andreamlin@codecov-io@garrettjonesgoogle