Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Update server streaming test helpers to include the request that started the call - #472

Merged
vam-google merged 1 commit into
googleapis:masterfrom
igorbernstein2:test-refactor
Feb 1, 2018
Merged

Update server streaming test helpers to include the request that started the call#472
vam-google merged 1 commit into
googleapis:masterfrom
igorbernstein2:test-refactor

Conversation

@igorbernstein2

@igorbernstein2igorbernstein2 commented Feb 1, 2018

Copy link
Copy Markdown
Contributor

Extracted this from #463 to cut down on the noise

@igorbernstein2igorbernstein2 changed the title Update test server streaming test helpers to include the request that started the callUpdate server streaming test helpers to include the request that started the callFeb 1, 2018
@codecov-io

codecov-io commented Feb 1, 2018

Copy link
Copy Markdown

Codecov Report

Merging #472 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #472 +/- ##
=========================================
Coverage 71.01% 71.01% Complexity 743 743 =========================================
Files 156 156 Lines 3340 3340 Branches 240 240 =========================================
Hits 2372 2372 Misses 875 875 Partials 93 93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3030ca8...7cf6ff7. Read the comment docs.

@vam-google
vam-google self-requested a review February 1, 2018 23:45

@vam-googlevam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vam-google
vam-google merged commit d720373 into googleapis:masterFeb 1, 2018
@igorbernstein2
igorbernstein2 deleted the test-refactor branch February 2, 2018 18:05
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2@codecov-io@vam-google