grpc: implement channel affinity by pongad · Pull Request #494 · googleapis/gax-java

pongad · 2018-03-12T05:02:51Z

Updates googleapis/google-cloud-java#3022.

codecov-io · 2018-03-12T05:06:09Z

Codecov Report

Merging #494 into master will decrease coverage by 0.06%.
The diff coverage is 72%.

@@ Coverage Diff @@## master #494 +/- ##
============================================
- Coverage 70.5% 70.43% -0.07% - Complexity 810 813 +3 
============================================
Files 165 165 Lines 3773 3781 +8 Branches 289 293 +4 ============================================
+ Hits 2660 2663 +3 - Misses 990 992 +2 - Partials 123 126 +3

Impacted Files	Coverage Δ	Complexity Δ
...va/com/google/api/gax/grpc/GrpcDirectCallable.java	`87.5% <100%> (-4.81%)`	`2 <0> (-1)`
...main/java/com/google/api/gax/grpc/ChannelPool.java	`28.2% <66.66%> (+0.42%)`	`5 <3> (+1)`	⬆️
.../java/com/google/api/gax/grpc/GrpcCallContext.java	`73.19% <71.42%> (-0.14%)`	`32 <5> (+2)`
.../java/com/google/api/gax/grpc/GrpcClientCalls.java	`83.33% <75%> (-5.56%)`	`3 <0> (+1)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4eae66...e08075f. Read the comment docs.

igorbernstein2 · 2018-03-12T18:28:28Z

Whoa, that was fast!

Sign in to view

+ ManagedChannel getChannel(int affinity) {
+ int index = affinity % channels.size();
+ index = Math.abs(index);
+ // If index is the most negative int, abs(index) is still negative.


Sign in to view

+ * reverse is not true: Two calls with different affinities might return the same channel.
+ * However, the implementation should attempt to spread load evenly.
+ */
+ ManagedChannel getChannel(int affinity) {


Sign in to view

 private final CallOptions callOptions;
 @Nullable private final Duration streamWaitTimeout;
 @Nullable private final Duration streamIdleTimeout;
+ @Nullable private final Integer channelAffinity;


Sign in to view


- return grpcContext.getChannel().newCall(descriptor, callOptions);
+ Channel channel = grpcContext.getChannel();
+ if (grpcContext.getChannelAffinity() != null && channel instanceof ChannelPool) {


vam-google

LGTM

Sign in to view

+ ManagedChannel getChannel(int affinity) {
+ int index = affinity % channels.size();
+ index = Math.abs(index);
+ // If index is the most negative int, abs(index) is still negative.


Sign in to view


- return grpcContext.getChannel().newCall(descriptor, callOptions);
+ Channel channel = grpcContext.getChannel();
+ if (grpcContext.getChannelAffinity() != null && channel instanceof ChannelPool) {


pongad · 2018-03-15T00:07:28Z

@vam-google Thank you for the review!

grpc: implement channel affinity
12a54c0
Updates googleapis/google-cloud-java#3022.

pongad requested review from garrettjonesgoogle and vam-google March 12, 2018 05:02

slight refactor; add tests
69dad55

vam-google reviewed Mar 13, 2018
View reviewed changes

pr comment
e08075f

vam-google approved these changes Mar 14, 2018
View reviewed changes

pongad merged commit 1e11861 into googleapis:masterMar 15, 2018

pongad deleted the chan-aff branch March 15, 2018 00:07

Uh oh!

Conversation

pongad commented Mar 12, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Mar 12, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

igorbernstein2 commented Mar 12, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

pongad commented Mar 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pongad commented Mar 12, 2018•
edited
Loading

codecov-io commented Mar 12, 2018•
edited
Loading