Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Batching - allow null entries - #496

Merged
garrettjonesgoogle merged 2 commits into
googleapis:masterfrom
igorbernstein2:batching-null-response
Mar 13, 2018
Merged

Batching - allow null entries#496
garrettjonesgoogle merged 2 commits into
googleapis:masterfrom
igorbernstein2:batching-null-response

Conversation

@igorbernstein2

Copy link
Copy Markdown
Contributor

This came out of working on googleapis/google-cloud-java#3026.

A Bigtable MutateRowsResponse contains a list of entries. Each entry simply contains a Status indicating if that entry succeeded or failed. Since the user only cares if the entry failed, the most useful type signature for a BatchingCallable representing the RPC would be BatchingCallable<MutateRowsRequest, Void>.

Unfortunately, BatchedRequestIssuer treats null response as absent. This PR adds an explicit hasResponse flag to check for missing responses, which allows for null responses for Void entries

@codecov-io

codecov-io commented Mar 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #496 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## master #496 +/- ##
===========================================
+ Coverage 70.5% 70.5% +<.01% 
Complexity 810 810 ===========================================
Files 165 165 Lines 3773 3774 +1 Branches 289 289 ===========================================
+ Hits 2660 2661 +1 
Misses 990 990 Partials 123 123
Impacted FilesCoverage ΔComplexity Δ
...a/com/google/api/gax/rpc/BatchedRequestIssuer.java100% <100%> (ø)9 <5> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4eae66...ccff79e. Read the comment docs.

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

LGTM

@garrettjonesgoogle
garrettjonesgoogle merged commit b0661c3 into googleapis:masterMar 13, 2018
@igorbernstein2
igorbernstein2 deleted the batching-null-response branch March 18, 2018 06:26
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@igorbernstein2@codecov-io@garrettjonesgoogle