Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Add an EmptyMessage class, analogous to protobuf's Empty - #678
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #678 +/- ##
============================================
- Coverage 75.71% 75.63% -0.09%
Complexity 1029 1029 ============================================
Files 194 195 +1 Lines 4608 4613 +5 Branches 356 356 ============================================
Hits 3489 3489 - Misses 961 966 +5
Partials 158 158
Continue to review full report at Codecov.
|
andreamlin
commented
Feb 21, 2019
ContributorAuthor
PTAL |
vam-google
approved these changes
Feb 21, 2019
vam-google
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor comments about javadoc.
| import javax.annotation.Nullable; | ||
| /** | ||
| * A generic empty message that you can re-use to avoid defining duplicated empty messages in your |
Contributor
There was a problem hiding this comment.
This is the first time I see a javadoc written in this style (talking to the reader directly). Usually javadoc just talks about the class (i.e. s/"you can re-use"/"can be reused"). Please consider rephrasing it.
| @Nullable | ||
| @Override | ||
| public Object getFieldValue(String fieldName) { |
Contributor
There was a problem hiding this comment.
Please add some documentation for the public methods of a public class. (or add in /** {@inheritDoc} */ blocks)
andreamlin added a commit
to googleapis/gapic-generator
that referenced
this pull request
Feb 21, 2019
This allows all interfaces that use `ApiMessage` to enforce that response objects have to be of type `ApiMessage`, which includes `EmptyMessage`. This replaces `java.lang.Void` as a response type. Goes along with [googleapis/gax-java#678](googleapis/gax-java#678).
andreamlin added a commit
to andreamlin/toolkit
that referenced
this pull request
Feb 27, 2019
…leapis#2585) This allows all interfaces that use `ApiMessage` to enforce that response objects have to be of type `ApiMessage`, which includes `EmptyMessage`. This replaces `java.lang.Void` as a response type. Goes along with [googleapis/gax-java#678](googleapis/gax-java#678).
andreamlin added a commit
to andreamlin/toolkit
that referenced
this pull request
Feb 27, 2019
…leapis#2585) This allows all interfaces that use `ApiMessage` to enforce that response objects have to be of type `ApiMessage`, which includes `EmptyMessage`. This replaces `java.lang.Void` as a response type. Goes along with [googleapis/gax-java#678](googleapis/gax-java#678).
andreamlin added a commit
to andreamlin/toolkit
that referenced
this pull request
Feb 27, 2019
…leapis#2585) This allows all interfaces that use `ApiMessage` to enforce that response objects have to be of type `ApiMessage`, which includes `EmptyMessage`. This replaces `java.lang.Void` as a response type. Goes along with [googleapis/gax-java#678](googleapis/gax-java#678).
andreamlin added a commit
to andreamlin/toolkit
that referenced
this pull request
Feb 27, 2019
…leapis#2585) This allows all interfaces that use `ApiMessage` to enforce that response objects have to be of type `ApiMessage`, which includes `EmptyMessage`. This replaces `java.lang.Void` as a response type. Goes along with [googleapis/gax-java#678](googleapis/gax-java#678).
andreamlin added a commit
to andreamlin/toolkit
that referenced
this pull request
Feb 27, 2019
update baselines support OperationApiCallable remove double @BetaApis remove BetaApi remove OperationsClients from LRO methods update java discogapic baseline remove Operation as the fourth type in OperationCallable<..> better? parameterize HttpJsonCallableFactory change Void to EmptyMessage add lroMetadataTransformer add in the piOperationTransformer give http_stub getOperationsStub() fix unit tests for http LRO return Region/Zone/GlobalOperationClient use ComputeLongRunningClientFactory parameterize all Global/Region/Zone operation names remove another GlobalOperation... let Discogapic metadata type be the Operaton ApimEssageOperationTransformers fixed! cleanup Use EmptyMessage instead of Void for HTTP response wrapper type (googleapis#2585) This allows all interfaces that use `ApiMessage` to enforce that response objects have to be of type `ApiMessage`, which includes `EmptyMessage`. This replaces `java.lang.Void` as a response type. Goes along with [googleapis/gax-java#678](googleapis/gax-java#678). remove a bunch of unnecessary things make EmptyMessage have a default builder value in tests cases generate OperationCallable generate the ApiLongRunningClientView formatting generating OperationSnapshotView Generating SimplecomputeLongRunningClientFactory but without actual tested generated constructors
andreamlin added a commit
to googleapis/gapic-generator
that referenced
this pull request
Mar 1, 2019
This allows all interfaces that use `ApiMessage` to enforce that response objects have to be of type `ApiMessage`, which includes `EmptyMessage`. This replaces `java.lang.Void` as a response type. Goes along with [googleapis/gax-java#678](googleapis/gax-java#678).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows all interfaces that use
ApiMessageto enforce that response objects have to be of typeApiMessage, which includesEmptyMessage. This replacesjava.lang.Voidas a response type.