Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
Add 200 as a valid HTTP status code - #679
Merged
Merged
Conversation
andreamlin
commented
Feb 21, 2019
ContributorAuthor
PTAL |
Codecov Report
@@ Coverage Diff @@## master #679 +/- ##
============================================
- Coverage 75.71% 75.69% -0.02%
Complexity 1029 1029 ============================================
Files 194 194 Lines 4608 4609 +1 Branches 356 356 ============================================
Hits 3489 3489 - Misses 961 962 +1
Partials 158 158
Continue to review full report at Codecov.
|
This was referenced Feb 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case users want to ping on status code, we have to be aware of 200s.