Uh oh!
There was an error while loading. Please reload this page.
Expose LRO callables for HttpJson - #684
Conversation
andreamlin
commented
Feb 22, 2019
PTAL |
Codecov Report
@@ Coverage Diff @@## master #684 +/- ##
===========================================
- Coverage 75.63% 75.5% -0.14%
Complexity 1029 1029 ===========================================
Files 195 195 Lines 4613 4621 +8 Branches 356 356 ===========================================
Hits 3489 3489 - Misses 966 974 +8
Partials 158 158
Continue to review full report at Codecov.
|
| * by generated code. | ||
| * | ||
| * @param httpJsonCallSettings the gRPC call settings | ||
| * @param callSettings the Unary call settings |
There was a problem hiding this comment.
Minor: should Unary start with capital letter here?
Codecov Report
@@ Coverage Diff @@## master #684 +/- ##
============================================
- Coverage 75.63% 75.51% -0.12% - Complexity 1029 1030 +1
============================================
Files 195 195 Lines 4613 4616 +3 Branches 356 357 +1 ============================================
- Hits 3489 3486 -3 - Misses 966 972 +6
Partials 158 158
Continue to review full report at Codecov.
|
Just the HttpJson version of GrpcStubCallableFactory and GrpcCallableFactory.
These new methods will be implemented by future versions of HttpJsonGlobalOperationStubCallableFactory, etc., in the same way that
com.google.longrunning.stub.GrpcOperationsCallableFactoryimplements GrpcStubCallableFactory.