Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Expose LRO callables for HttpJson - #684

Merged
andreamlin merged 2 commits into
googleapis:masterfrom
andreamlin:operation_callable_lro
Feb 23, 2019
Merged

Expose LRO callables for HttpJson#684
andreamlin merged 2 commits into
googleapis:masterfrom
andreamlin:operation_callable_lro

Conversation

@andreamlin

@andreamlinandreamlin commented Feb 22, 2019

Copy link
Copy Markdown
Contributor

Just the HttpJson version of GrpcStubCallableFactory and GrpcCallableFactory.

These new methods will be implemented by future versions of HttpJsonGlobalOperationStubCallableFactory, etc., in the same way that com.google.longrunning.stub.GrpcOperationsCallableFactory implements GrpcStubCallableFactory.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2019
@andreamlin

Copy link
Copy Markdown
ContributorAuthor

PTAL

@codecov

codecovBot commented Feb 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #684 into master will decrease coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #684 +/- ##
===========================================
- Coverage 75.63% 75.5% -0.14% 
Complexity 1029 1029 ===========================================
Files 195 195 Lines 4613 4621 +8 Branches 356 356 ===========================================
Hits 3489 3489 - Misses 966 974 +8 
Partials 158 158
Impacted FilesCoverage ΔComplexity Δ
...ogle/api/gax/httpjson/HttpJsonCallableFactory.java24.24% <0%> (-7.76%)3 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007caf3...74f85f7. Read the comment docs.

@vam-googlevam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* by generated code.
*
* @param httpJsonCallSettings the gRPC call settings
* @param callSettings the Unary call settings

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: should Unary start with capital letter here?

@codecov-io

codecov-io commented Feb 22, 2019

Copy link
Copy Markdown

Codecov Report

Merging #684 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@ Coverage Diff @@## master #684 +/- ##
============================================
- Coverage 75.63% 75.51% -0.12% - Complexity 1029 1030 +1 
============================================
Files 195 195 Lines 4613 4616 +3 Branches 356 357 +1 ============================================
- Hits 3489 3486 -3 - Misses 966 972 +6 
Partials 158 158
Impacted FilesCoverage ΔComplexity Δ
...ogle/api/gax/httpjson/HttpJsonCallableFactory.java24.24% <0%> (-7.76%)3 <0> (ø)
...a/com/google/api/gax/tracing/OpencensusTracer.java87.5% <0%> (+0.29%)32% <0%> (+1%)⬆️
...api/gax/tracing/TracedServerStreamingCallable.java100% <0%> (+8.69%)2% <0%> (ø)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007caf3...b10b624. Read the comment docs.

@andreamlin
andreamlin merged commit ba0c6b9 into googleapis:masterFeb 23, 2019
This was referenced Feb 28, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@andreamlin@codecov-io@vam-google@googlebot