Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Fix default timeout for non-retryable operations - #745

Merged
chingor13 merged 6 commits into
googleapis:masterfrom
chingor13:default-deadline-single-call
Jun 27, 2019
Merged

Fix default timeout for non-retryable operations#745
chingor13 merged 6 commits into
googleapis:masterfrom
chingor13:default-deadline-single-call

Conversation

@chingor13

@chingor13chingor13 commented Jun 26, 2019

Copy link
Copy Markdown
Contributor

We should prefer an individual timeout configured for the RPC call over the totalTimeout setting for non-retryable RPC calls.

Fixesgoogleapis/google-cloud-java#5555

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2019
@codecov

codecovBot commented Jun 27, 2019

Copy link
Copy Markdown

Codecov Report

Merging #745 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@ Coverage Diff @@## master #745 +/- ##
============================================
- Coverage 77.72% 77.71% -0.01% - Complexity 1094 1096 +2 
============================================
Files 198 198 Lines 4799 4806 +7 Branches 377 379 +2 ============================================
+ Hits 3730 3735 +5 - Misses 898 899 +1 - Partials 171 172 +1
Impacted FilesCoverage ΔComplexity Δ
...rc/main/java/com/google/api/gax/rpc/Callables.java67.85% <66.66%> (+0.51%)12 <2> (+2)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b3357c...a1ccea5. Read the comment docs.

Comment threadgax/src/main/java/com/google/api/gax/rpc/Callables.java Outdated
Comment threadgax/src/main/java/com/google/api/gax/rpc/Callables.java

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New Cloud Tasks Library has breaking changes

3 participants

@chingor13@igorbernstein2@googlebot