Skip to content

feat: Provide HttpTransport support for google certificates with apache HTTP client v5 (#2497) - #2503

Merged
ldetmer merged 24 commits into
mainfrom
apache-v5-upgrade
Aug 27, 2024
Merged

feat: Provide HttpTransport support for google certificates with apache HTTP client v5 (#2497)#2503
ldetmer merged 24 commits into
mainfrom
apache-v5-upgrade

Conversation

@ldetmer

@ldetmerldetmer commented Aug 14, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#2497 ☕️

@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Aug 14, 2024•
edited
Loading

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-labelproduct-auto-labelBot added the size: l Pull request size is large. label Aug 14, 2024
burkedavison
burkedavison reviewed Aug 22, 2024
View reviewed changes
Comment threadgoogle-api-client-apache-v5/pom.xml Outdated
Comment threadgoogle-api-client-apache-v5/pom.xml Outdated
Comment thread...-v5/src/main/java/com/google/api/client/googleapis/apache/v5/GoogleApache5HttpTransport.java Outdated
Comment thread...le-api-client/src/test/java/com/google/api/client/googleapis/mtls/MtlsTransportBaseTest.java Outdated
@ldetmer
ldetmer marked this pull request as ready for review August 22, 2024 20:52
@ldetmer
ldetmer requested review from a team and diegomarquezpAugust 22, 2024 20:52
diegomarquezp
diegomarquezp reviewed Aug 23, 2024
View reviewed changes

@diegomarquezpdiegomarquezp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, thanks! Just a few comments + a nit on the pom and docs

Comment threaddocs/component-modules.md Outdated
Comment threadgoogle-api-client-apache-v5/pom.xml Outdated
Comment threadgoogle-api-client-apache-v5/pom.xml Outdated
Comment thread...c/test/java/com/google/api/client/googleapis/apache/v5/ITGoogleApache5HttpTransportTest.java

@diegomarquezpdiegomarquezpAug 23, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format checker will probably complain for a missing license header in this file.

@ldetmerldetmerAug 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you're looking at old version of the file?

@diegomarquezpdiegomarquezpAug 27, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed! Please disregard.

@ldetmer
ldetmer merged commit 0d39b43 into mainAug 27, 2024
@ldetmer
ldetmer deleted the apache-v5-upgrade branch August 27, 2024 15:52
@release-pleaserelease-pleaseBot mentioned this pull request Aug 27, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@burkedavisonburkedavisonburkedavison left review comments
+1 more reviewer
@diegomarquezpdiegomarquezpdiegomarquezp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Start using core5 and client5 libraries as core(4) and client(4) haven't changed since 2022

3 participants

@ldetmer@diegomarquezp@burkedavison