Uh oh!
There was an error while loading. Please reload this page.
feat: add client_options support for api endpoint override - #829
Merged
Conversation
plamut
reviewed
Feb 29, 2020
Uh oh!
There was an error while loading. Please reload this page.
plamut
reviewed
Mar 11, 2020
plamut
left a comment
There was a problem hiding this comment.
Apart from two suggestions, this might be a good chance to replace all deprecated self.assertEquals() with the recommended self.assertEqual() if it's not totally out of scope.
The Kokoro config changes look fine on the surface, but I don't really know much about them, thus cannot really comment on that.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
plamut
reviewed
Mar 12, 2020
plamut
left a comment
There was a problem hiding this comment.
Looks good now, we just need to resolve a merge conflict.
plamut
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no manipulation of the endpoint url passed (e.g.,
storage.googleapis.com->https://foo.googleapis.combut am happy to be convinced to do otherwise.Replacement for #705.
Also sneaking in some kokoro config shuffling into this PR. (The status check named "Kokoro" is the real one.)