Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: send quota project id in x-goog-user-project for OAuth2 credentials - #400

Merged
busunkim96 merged 4 commits into
googleapis:masterfrom
busunkim96:add-quota-project
Dec 6, 2019
Merged

feat: send quota project id in x-goog-user-project for OAuth2 credentials#400
busunkim96 merged 4 commits into
googleapis:masterfrom
busunkim96:add-quota-project

Conversation

@busunkim96

@busunkim96busunkim96 commented Dec 5, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

When the 3LO credentials are used, the quota project ("quota_project_id") should be sent on every outgoing request in the x-goog-user-project HTTP header/grpc metadata.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2019
tmatsuo
tmatsuo reviewed Dec 5, 2019
View reviewed changes
Comment threadtests/oauth2/test_credentials.py Outdated
broady
broady reviewed Dec 5, 2019
View reviewed changes
Comment threadgoogle/oauth2/credentials.py Outdated
@busunkim96busunkim96 changed the title feat: send quota project in x-goog-user-project for OAuth2 credentialsfeat: send quota project id in x-goog-user-project for OAuth2 credentialsDec 5, 2019
@broady

broady commented Dec 5, 2019

Copy link
Copy Markdown

LGTM, PTAL @shinfan / @CodingFanSteve

@shinfan

shinfan commented Dec 5, 2019•
edited
Loading

Copy link
Copy Markdown

LGTM. Thanks.

Just wanna mention we will also need this quota project as a client-level option.

@wora FYI

@busunkim96busunkim96 mentioned this pull request Dec 6, 2019
Merged
@busunkim96

busunkim96 commented Dec 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@shinfan@broady Thank you for the fast reviews! Is sometime late in Q1 an acceptable timeframe for adding this as a client-level option? I'd prefer to be done with the transition to the Python microgenerator to avoid doing the work twice. 😄

@shinfan

shinfan commented Dec 6, 2019

Copy link
Copy Markdown

late Q1 sounds good to me :) Thank you!

@busunkim96
busunkim96 merged commit ab3dc1e into googleapis:masterDec 6, 2019
@srulkapara

srulkapara commented Dec 10, 2019

Copy link
Copy Markdown

@busunkim96 just a quick note that this code is not fully backward-compatible (not talking about constrcutors - i mean in terms of already-pickled creds-token-files, who are missing the new member - who has no default on __setstate__).
Some of Google's best-practices/demo-quickstarts include pickling these tokens to files, so they will be broken after this merge (while not changing the minor module-version). maybe we should cover those cases as well..
(happened to me, thought maybe you should know)

@busunkim96

busunkim96 commented Dec 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@srulkapara Thank you for the heads up! I'll continue to track this in #405

busunkim96 added a commit that referenced this pull request Dec 10, 2019
@busunkim96
Revert "feat: send quota project id in x-goog-user-project header for…
2561ff2
… OAuth2 credentials (#400)"
This reverts commit ab3dc1e.
@busunkim96busunkim96 mentioned this pull request Dec 10, 2019
Merged
busunkim96 added a commit that referenced this pull request Dec 11, 2019
@busunkim96
fix: revert "feat: send quota project id in x-goog-user-project heade…
25ea942
…r for OAuth2 credentials (#400)" (#407)
This reverts commit ab3dc1e.
busunkim96 added a commit to busunkim96/google-auth-library-python that referenced this pull request Dec 16, 2019
@busunkim96
feat: send quota project id in x-goog-user-project header for OAuth2 …
b9a75f2
…credentials (googleapis#400)
When the 3LO credentials are used, the quota project ("quota_project_id") is sent on every outgoing request in the x-goog-user-project HTTP header/grpc metadata. The quota project is used for billing and quota purposes.
@busunkim96busunkim96 mentioned this pull request Dec 16, 2019
Merged
busunkim96 added a commit that referenced this pull request Dec 18, 2019
@busunkim96
feat: send quota project id in x-goog-user-project for OAuth2 credent…
32d71a5
…ials (#412)
* feat: send quota project id in x-goog-user-project header for OAuth2 credentials (#400)
When the 3LO credentials are used, the quota project ("quota_project_id") is sent on every outgoing request in the x-goog-user-project HTTP header/grpc metadata. The quota project is used for billing and quota purposes.
* feat: add `__setstate__` and `__getstate__` to `oauth2.credentials` class
@yoshi-automationyoshi-automation mentioned this pull request Jan 22, 2020
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@michaelawyumichaelawyuAwaiting requested review from michaelawyu
3 more reviewers
@tmatsuotmatsuotmatsuo left review comments
@broadybroadybroady approved these changes
@jeanbzajeanbzajeanbza approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@busunkim96@broady@shinfan@srulkapara@tmatsuo@jeanbza@googlebot