Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: make collections import compatible across Python versions - #419

Merged
plamut merged 3 commits into
googleapis:masterfrom
jay0lee:patch-1
Jan 17, 2020
Merged

fix: make collections import compatible across Python versions#419
plamut merged 3 commits into
googleapis:masterfrom
jay0lee:patch-1

Conversation

@jay0lee

@jay0leejay0lee commented Jan 8, 2020

Copy link
Copy Markdown
Contributor

Fixes#418.

Use collections.abc.Mapping instead of deprecated collections.Mapping that will be removed with Python 3.9.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2020
@jay0leejay0lee changed the title Use collections.abc, fixes #418fix: Use collections.abc, fixes #418Jan 8, 2020
@busunkim96busunkim96 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 8, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 8, 2020

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jay0lee Thanks for the fix!

Unfortunately, this library technically still supports Python 2.7, thus the import needs to be made in a compatible way for a little longer.

(the README does say January 1st 2020, but IIRC the support is extended until April 2020 when the last Python 2.7 bugfix release is made)

@plamutplamut changed the title fix: Use collections.abc, fixes #418fix: make collections import compatible across Python versionsJan 17, 2020

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure with Python 3.9 due to use of deprecated collections.Mapping

5 participants

@jay0lee@plamut@googlebot@busunkim96@yoshi-kokoro