Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: Pluggable auth support - #995

Merged
arithmetic1728 merged 58 commits into
mainfrom
pluggable
May 10, 2022
Merged

feat: Pluggable auth support#995
arithmetic1728 merged 58 commits into
mainfrom
pluggable

Conversation

@renkelvin

@renkelvinrenkelvin commented Mar 17, 2022

Copy link
Copy Markdown
Contributor

Adding pluggable auth support.

Chuan Ren added 2 commits March 1, 2022 14:14
Chuan Ren
feat: Add Pluggable auth support (#988)
63ad5e9
* Port identity pool credentials
* access_token retrieved
* -> pluggable
* Update pluggable.py
* Create test_pluggable.py
* Unit tests
* Address pr issues
Chuan Ren
feat: Add file caching (#990)
f36e5e8
* Add file cache
* feat: add output file cache support
@renkelvin
renkelvin requested a review from a teamMarch 17, 2022 16:18
@renkelvinrenkelvin changed the title Pluggable auth supportfeat: Pluggable auth support [Do not merge]Mar 17, 2022
@arithmetic1728arithmetic1728 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 17, 2022
lsirac
lsirac reviewed Mar 17, 2022
View reviewed changes

@lsiraclsirac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. I didn't review the tests. Thanks Chuan!

Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py
Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py
Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py Outdated
@renkelvin

renkelvin commented Mar 18, 2022

Copy link
Copy Markdown
ContributorAuthor

Hmm, I can't push to the pluggable branch. I may need to create a new pr from my fork.

@renkelvin

renkelvin commented Mar 18, 2022

Copy link
Copy Markdown
ContributorAuthor

Hey @arithmetic1728, mind giving me the temporary write access to this repo? It should make the review much easier.

@arithmetic1728

arithmetic1728 commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

@renkelvin you need to join https://github.com/googleapis first, then I can give you temporary write access

@renkelvin

renkelvin commented Mar 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@renkelvin you need to join https://github.com/googleapis first, then I can give you temporary write access

Done joining https://github.com/googleapis

@arithmetic1728

arithmetic1728 commented Mar 19, 2022

Copy link
Copy Markdown
Contributor

@renkelvin I just gave you the write access, let me know if it doesn't work.

@renkelvin

renkelvin commented Mar 19, 2022

Copy link
Copy Markdown
ContributorAuthor

@renkelvin I just gave you the write access, let me know if it doesn't work.

It works, thanks!

lsirac
lsirac reviewed Mar 21, 2022
View reviewed changes
Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py Outdated
Comment threadgoogle/auth/pluggable.py Outdated
@renkelvin

renkelvin commented Mar 23, 2022

Copy link
Copy Markdown
ContributorAuthor

@arithmetic1728 Any ideas how can I add pytest_subprocess as a dev dependency just for testing purpose? Thanks! https://source.cloud.google.com/results/invocations/e6b81a67-add0-4bfa-9089-fe92b4cc7007/targets/github%2Fgoogle-auth-library-python/tests

@arithmetic1728

arithmetic1728 commented Mar 23, 2022

Copy link
Copy Markdown
Contributor

@renkelvin I think you can add it here: https://github.com/googleapis/google-auth-library-python/blob/main/testing/requirements.txt

@arithmetic1728

arithmetic1728 commented May 5, 2022

Copy link
Copy Markdown
Contributor

You can run the following easily-to-fail kokoro tests locally before pushing to github. This will save a lot of time. (Don't worry about the kokoro system-3.7 failure - It is caused by expired creds. I will update the creds once your PR is ready to merge).

lint: python -m nox -s lint
If lint fails, run python -m nox -s blacken to format the files, then re-run lint. If it can pass, don't forget to add and commit the changes.

cover: python -m nox -s cover

@renkelvin

renkelvin commented May 9, 2022

Copy link
Copy Markdown
ContributorAuthor

You can run the following easily-to-fail kokoro tests locally before pushing to github. This will save a lot of time. (Don't worry about the kokoro system-3.7 failure - It is caused by expired creds. I will update the creds once your PR is ready to merge).

lint: python -m nox -s lint If lint fails, run python -m nox -s blacken to format the files, then re-run lint. If it can pass, don't forget to add and commit the changes.

cover: python -m nox -s cover

Thanks @arithmetic1728! The CI passes now.

@arithmetic1728

arithmetic1728 commented May 9, 2022

Copy link
Copy Markdown
Contributor

LGTM

@sai-sunder-s would you like to take another look?
@renkelvin I will fix the system test in a separate PR when we are ready to check in.

@arithmetic1728arithmetic1728 changed the title feat: Pluggable auth support [Do not merge]feat: Pluggable auth supportMay 10, 2022
@arithmetic1728
arithmetic1728 merged commit 62daa73 into mainMay 10, 2022
@arithmetic1728
arithmetic1728 deleted the pluggable branch May 10, 2022 18:30
@release-pleaserelease-pleaseBot mentioned this pull request May 10, 2022
Merged
arithmetic1728 added a commit that referenced this pull request May 10, 2022
@arithmetic1728
revert: pluggable auth support#995
c321e39
@arithmetic1728arithmetic1728 mentioned this pull request May 10, 2022
Merged
arithmetic1728 added a commit that referenced this pull request May 11, 2022
@arithmetic1728
revert: pluggable auth support#995(#1039)
513d999
@renkelvin
renkelvin restored the pluggable branch May 27, 2022 17:28
@renkelvinrenkelvin mentioned this pull request May 27, 2022
Merged
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jun 7, 2022
@release-please
chore(main): release 2.7.0 (#1036)
49bb805
🤖 I have created a release *beep* *boop*
---
## [2.7.0](v2.6.6...v2.7.0) (2022-06-07)
### Features
* add experimental enterprise cert support ([#1052](#1052)) ([dda7dda](dda7dda))
* add experimental GDCH support ([#1022](#1022)) ([5367aac](5367aac))
* Pluggable auth support ([#995](#995)) ([62daa73](62daa73))
### Bug Fixes
* validate urls for external accounts ([#1031](#1031)) ([61b1f15](61b1f15))
### Reverts
* pluggable auth support [#995](#995) ([#1039](#1039)) ([513d999](513d999))
* revert experimental GDCH support ([#1022](#1022)) ([#1042](#1042)) ([c720995](c720995))
### Documentation
* fix changelog header to consistent size ([#1046](#1046)) ([e64d084](e64d084))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Nov 26, 2025
@release-please
chore(main): release 2.7.0 (#1036)
9321953
🤖 I have created a release *beep* *boop*
---
## [2.7.0](googleapis/google-auth-library-python@v2.6.6...v2.7.0) (2022-06-07)
### Features
* add experimental enterprise cert support ([#1052](googleapis/google-auth-library-python#1052)) ([dda7dda](googleapis/google-auth-library-python@dda7dda))
* add experimental GDCH support ([#1022](googleapis/google-auth-library-python#1022)) ([5367aac](googleapis/google-auth-library-python@5367aac))
* Pluggable auth support ([#995](googleapis/google-auth-library-python#995)) ([62daa73](googleapis/google-auth-library-python@62daa73))
### Bug Fixes
* validate urls for external accounts ([#1031](googleapis/google-auth-library-python#1031)) ([61b1f15](googleapis/google-auth-library-python@61b1f15))
### Reverts
* pluggable auth support [#995](googleapis/google-auth-library-python#995) ([#1039](googleapis/google-auth-library-python#1039)) ([513d999](googleapis/google-auth-library-python@513d999))
* revert experimental GDCH support ([#1022](googleapis/google-auth-library-python#1022)) ([#1042](googleapis/google-auth-library-python#1042)) ([c720995](googleapis/google-auth-library-python@c720995))
### Documentation
* fix changelog header to consistent size ([#1046](googleapis/google-auth-library-python#1046)) ([e64d084](googleapis/google-auth-library-python@e64d084))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@lsiraclsiraclsirac approved these changes
@sai-sunder-ssai-sunder-ssai-sunder-s approved these changes
@arithmetic1728arithmetic1728arithmetic1728 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@renkelvin@arithmetic1728@sai-sunder-s@lsirac