Skip to content

feat(bigtable): introduce PartialResultSetSource - #15598

Merged
mpeddada1 merged 27 commits into
googleapis:mainfrom
mpeddada1:partial-result-source
Oct 14, 2025
Merged

feat(bigtable): introduce PartialResultSetSource#15598
mpeddada1 merged 27 commits into
googleapis:mainfrom
mpeddada1:partial-result-source

Conversation

@mpeddada1

@mpeddada1mpeddada1 commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

This PR introduces the PartialResultSetSource class. For processing data, the logic in the PR follows the pattern established by https://github.com/googleapis/googleapis/blob/4b1fe4dbb4156c42e9d09c294d74f36c7a3fc4ac/google/bigtable/v2/data.proto#L749-L770. Some things to note:

  • Bigtable automatically sets the sentinel resume_token on the last batch of data read.
  • The bigtable server also sends an error when the row size limit is reached (for reads).

Validation of the batch checksum will be done separately in a follow-up PR: #15617

@mpeddada1
mpeddada1 requested a review from a teamOctober 9, 2025 05:22
@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the Bigtable API. label Oct 9, 2025
@mpeddada1mpeddada1 changed the title feat(bigtable): introduce PartialResultSetSource[Not ready for review] feat(bigtable): introduce PartialResultSetSourceOct 9, 2025
@codecov

codecovBot commented Oct 9, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.45907% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.10%. Comparing base (393d5a9) to head (0d5d56c).
⚠️ Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
...oud/bigtable/internal/partial_result_set_source.cc79.24%22 Missing ⚠️
...loud/bigtable/internal/partial_result_set_source.h0.00%2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #15598 +/- ##
==========================================
- Coverage 93.11% 93.10% -0.01% 
==========================================
Files 2418 2424 +6 Lines 222977 223259 +282 ==========================================
+ Hits 207618 207865 +247 - Misses 15359 15394 +35 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpeddada1mpeddada1 changed the title [Not ready for review] feat(bigtable): introduce PartialResultSetSourcefeat(bigtable): introduce PartialResultSetSourceOct 10, 2025
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_reader.h Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.h Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.h Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.cc
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.cc Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.cc Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.cc Outdated
Comment threadgoogle/cloud/bigtable/options.h Outdated
Comment threadgoogle/cloud/bigtable/options.h Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.h Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.cc Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.h Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.h Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.cc Outdated
Comment threadgoogle/cloud/bigtable/internal/partial_result_set_source.cc
@mpeddada1
mpeddada1 merged commit e6692f8 into googleapis:mainOct 14, 2025
65 of 71 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtableIssues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mpeddada1@meltsufin@scotthart