Uh oh!
There was an error while loading. Please reload this page.
cleanup(storage): remove testbench hack for XML - #5097
Merged
coryan merged 1 commit intoSep 19, 2020
Conversation
Cleanup the library and the testbench to use the same paths for the XML API on the testbench as we use in production. Wrote a test to verify the testbench can be used via `ClientOptions::set_endpoint()`.
Codecov Report
@@ Coverage Diff @@## master #5097 +/- ##
==========================================
- Coverage 95.82% 95.82% -0.01%
==========================================
Files 986 986 Lines 90282 90350 +68 ==========================================
+ Hits 86516 86577 +61 - Misses 3766 3773 +7
Continue to review full report at Codecov.
|
coryan
marked this pull request as ready for review
September 19, 2020 12:38
devbww
approved these changes
Sep 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup the library and the testbench to use the same paths for the XML
API on the testbench as we use in production. Wrote a test to verify the
testbench can be used via
ClientOptions::set_endpoint().Part of the work for #5072
This change is