Skip to content

Fix Sink.update/delete and add snippets for Sink class - #1222

Merged
mziccard merged 3 commits into
googleapis:masterfrom
mziccard:sink-snippets
Sep 5, 2016
Merged

Fix Sink.update/delete and add snippets for Sink class#1222
mziccard merged 3 commits into
googleapis:masterfrom
mziccard:sink-snippets

Conversation

@mziccard

Copy link
Copy Markdown
Contributor

This PR does the following:

  • Remove unnecessary SinkInfo parameter for Sink.update and Sink.updateAsync
  • Fix deleteSink to properly return false on NOT_FOUND
  • Add snippets to Sink's javadoc, SinkSnippets class and tests

@mziccardmziccard added docs api: logging Issues related to the Cloud Logging API. labels Sep 1, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2016
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.005%) to 85.197% when pulling fbd8c49 on mziccard:sink-snippets into 7309be5 on GoogleCloudPlatform:master.

@mziccard

Copy link
Copy Markdown
ContributorAuthor

/cc @lesv

@lesv

lesv commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

LGTM

@mziccard
mziccard merged commit 3ea98b1 into googleapis:masterSep 5, 2016
@mziccardmziccard changed the title Fix Metric.update/delete and add snippets for Metric classFix Sink.update/delete and add snippets for Sink classSep 8, 2016
@mziccardmziccard mentioned this pull request Sep 8, 2016
github-actionsBot pushed a commit that referenced this pull request Aug 24, 2022
🤖 I have created a release *beep* *boop*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
🤖 I have created a release *beep* *boop*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
Source-Link: googleapis/synthtool@c06d605
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6f431774e11cc46619cf093fd1481193c4024031073697fa18f0099b943aab88
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
…26.0 (#1222)
* chore(deps): update dependency com.google.cloud:libraries-bom to v26.26.0
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
🤖 I have created a release *beep* *boop*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
🤖 I have created a release *beep* *boop*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
🤖 I have created a release *beep* *boop*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
…jdbc to v2.9.14 (googleapis#1222)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-spanner-jdbc](https://togithub.com/googleapis/java-spanner-jdbc) | `2.9.13` -> `2.9.14` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-spanner-jdbc/2.9.14/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-spanner-jdbc/2.9.14/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-spanner-jdbc/2.9.14/compatibility-slim/2.9.13)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-spanner-jdbc/2.9.14/confidence-slim/2.9.13)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-spanner-jdbc</summary>
### [`v2.9.14`](https://togithub.com/googleapis/java-spanner-jdbc/blob/HEAD/CHANGELOG.md#&#8203;2914-httpsgithubcomgoogleapisjava-spanner-jdbccomparev2913v2914-2023-05-02)
[Compare Source](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.9.13...v2.9.14)
##### Dependencies
- Update dependency com.google.cloud:google-cloud-spanner-bom to v6.41.0 ([#&googleapis#8203;1216](https://togithub.com/googleapis/java-spanner-jdbc/issues/1216)) ([5e69512](https://togithub.com/googleapis/java-spanner-jdbc/commit/5e695121f7bdbc0fa0256e7a4525f5172f1ff75b))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner-jdbc).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OC4yIiwidXBkYXRlZEluVmVyIjoiMzUuNDguMiJ9-->
suztomo pushed a commit that referenced this pull request Mar 30, 2026
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
…1222)
* deps: update dependency com.google.cloud:google-cloud-core to v2.8.6
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
🤖 I have created a release *beep* *boop*
---
## [1.120.8](googleapis/java-pubsub@v1.120.7...v1.120.8) (2022-08-02)
### Dependencies
* update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#1222](googleapis/java-pubsub#1222)) ([55eebf5](googleapis/java-pubsub@55eebf5))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 1, 2026
…1222)
* deps: update dependency com.google.cloud:google-cloud-core to v2.8.6
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
🤖 I have created a release *beep* *boop*
---
## [1.120.8](googleapis/java-pubsub@v1.120.7...v1.120.8) (2022-08-02)
### Dependencies
* update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#1222](googleapis/java-pubsub#1222)) ([af3a8dd](googleapis/java-pubsub@af3a8dd))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
…3.1 (googleapis#1222)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:native-image-support](https://togithub.com/googleapis/java-core) | `0.12.11` -> `0.13.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:native-image-support/0.13.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:native-image-support/0.13.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:native-image-support/0.13.1/compatibility-slim/0.12.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:native-image-support/0.13.1/confidence-slim/0.12.11)](https://docs.renovatebot.com/merge-confidence/) |
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigtable).
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
🤖 I have created a release *beep* *boop*
---
### [2.6.2](googleapis/java-bigtable@v2.6.1...v2.6.2) (2022-04-15)
### Dependencies
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([googleapis#1221](googleapis/java-bigtable#1221)) ([6eb08f0](googleapis/java-bigtable@6eb08f0))
* update dependency com.google.cloud:native-image-support to v0.13.1 ([googleapis#1222](googleapis/java-bigtable#1222)) ([0437988](googleapis/java-bigtable@0437988))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: loggingIssues related to the Cloud Logging API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mziccard@coveralls@lesv@googlebot