Skip to content

chore: migrate java-storage-nio to google-cloud-java - #12311

Merged
suztomo merged 1778 commits into
mainfrom
migrate-java-storage-nio
Apr 1, 2026
Merged

chore: migrate java-storage-nio to google-cloud-java#12311
suztomo merged 1778 commits into
mainfrom
migrate-java-storage-nio

Conversation

@suztomo

Copy link
Copy Markdown
Member

b/477663567

release-pleaseBotand others added 30 commits August 13, 2024 19:01
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore: disable owlbot
* remove required check
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@suztomo
suztomo marked this pull request as ready for review March 30, 2026 20:30
@suztomo
suztomo requested a review from a team as a code ownerMarch 30, 2026 20:30
@snippet-bot

snippet-botBot commented Mar 30, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo
suztomo requested a review from chingor13March 30, 2026 20:30
@suztomo

Copy link
Copy Markdown
MemberAuthor

Got conflicts.

@suztomo
suztomoforce-pushed the migrate-java-storage-nio branch from 6988d56 to 16dad05CompareMarch 30, 2026 21:29
@suztomo
suztomo requested a review from blakeli0March 31, 2026 14:42
@suztomo
suztomoforce-pushed the migrate-java-storage-nio branch from 16dad05 to ce6327bCompareMarch 31, 2026 16:14
@suztomo

Copy link
Copy Markdown
MemberAuthor

Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.6.0:check (checkstyle) on project google-cloud-nio-examples: Failed during checkstyle execution: Unable to find configuration file at location: license-checks.xml: Could not find resource 'license-checks.xml'. -> [Help 1]

@suztomo

Copy link
Copy Markdown
MemberAuthor

Placing the license-checks.xml brought the next errors:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.6.0:check (checkstyle) on project google-cloud-nio-examples: Failed during checkstyle execution: Failed during checkstyle configuration: unable to parse configuration stream: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Property ${checkstyle.header.file} has not been set -> [Help 1]
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.6.0:check (checkstyle) on project google-cloud-nio-retrofit: Failed during checkstyle execution: Failed during checkstyle configuration: unable to parse configuration stream: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Property ${checkstyle.header.file} has not been set -> [Help 1]

@suztomo
suztomoforce-pushed the migrate-java-storage-nio branch 3 times, most recently from 78e28ea to 05c7152CompareMarch 31, 2026 19:25
@suztomo

Copy link
Copy Markdown
MemberAuthor

https://productionresultssa19.blob.core.windows.net/actions-results/7868a8ba-db07-40ba-ab02-e786cb7cdf1c/workflow-job-run-07dc4418-1d1f-52f6-9952-56926375ef87/logs/job/job-logs.txt?rsct=text%2Fplain&se=2026-03-31T22%3A02%3A40Z&sig=%2FBdCzbjOKgStLiBWS6zFDNSlw8Z6VVrkmARSzSX%2F5Iw%3D&ske=2026-04-01T01%3A25%3A44Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2026-03-31T21%3A25%3A44Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2025-11-05&sp=r&spr=https&sr=b&st=2026-03-31T21%3A52%3A35Z&sv=2025-11-05

It doesn't seem to have java-core dependencies are not correctly built:

2026-03-31T19:41:33.6527256Z [ERROR] Failed to execute goal on project google-cloud-notification: Could not resolve dependencies for project com.google.cloud:google-cloud-notification:jar:0.207.0-beta-SNAPSHOT
2026-03-31T19:41:33.6527815Z [ERROR] dependency: com.google.cloud:google-cloud-core-http:jar:2.66.1-SNAPSHOT (compile)
2026-03-31T19:41:33.6528868Z [ERROR] Could not find artifact com.google.cloud:google-cloud-core-http:jar:2.66.1-SNAPSHOT in google-maven-central-copy (https://maven-central.storage-download.googleapis.com/maven2)
2026-03-31T19:41:33.6529676Z [ERROR] Could not find artifact com.google.cloud:google-cloud-core-http:jar:2.66.1-SNAPSHOT in maven-central (https://repo1.maven.org/maven2)

@suztomo

Copy link
Copy Markdown
MemberAuthor
2026-03-31T19:41:31.1479345Z [INFO] ------------------------------------------------------------------------
2026-03-31T19:41:31.1481007Z [INFO] Skipping Google Cloud Core HTTP
2026-03-31T19:41:31.1482504Z [INFO] This project has been banned from the build due to previous failures.
2026-03-31T19:41:31.1483862Z [INFO] ------------------------------------------------------------------------
...
2026-03-31T19:41:33.5455639Z [INFO] Google Cloud Core HTTP 2.66.1-SNAPSHOT ............. SKIPPED

Maybe temporary failure?

@suztomo

Copy link
Copy Markdown
MemberAuthor
19:46:35:344 [ERROR] com.google.api.gax.logging.Slf4jUtilsTest.testGetLogger_loggingDisabled_shouldGetNOPLogger -- Time elapsed: 0.007 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <org.slf4j.helpers.NOPLogger> but was: <com.google.api.gax.logging.TestLogger>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)

@suztomo
suztomoforce-pushed the migrate-java-storage-nio branch from 05c7152 to 3e1dbc5CompareApril 1, 2026 03:23
@suztomo

suztomo commented Apr 1, 2026

Copy link
Copy Markdown
MemberAuthor

ci / enforcer failed (log):

2026-04-01T03:46:57.1100526Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce) on project google-cloud-nio: 2026-04-01T03:46:57.1101085Z [ERROR] Rule 0: org.apache.maven.enforcer.rules.dependency.RequireUpperBoundDeps failed with message:
2026-04-01T03:46:57.1101479Z [ERROR] Failed while enforcing RequireUpperBoundDeps. The error(s) are [
2026-04-01T03:46:57.1102282Z [ERROR] Require upper bound dependencies error for com.fasterxml.jackson.core:jackson-core:2.18.2 paths to dependency are:
2026-04-01T03:46:57.1102493Z [ERROR] +-com.google.cloud:google-cloud-nio:0.128.14
2026-04-01T03:46:57.1102763Z [ERROR] +-com.google.cloud:google-cloud-storage:2.64.2-SNAPSHOT
2026-04-01T03:46:57.1103388Z [ERROR] +-com.fasterxml.jackson.core:jackson-core:2.18.2 (managed) <-- com.fasterxml.jackson.core:jackson-core:2.18.2
2026-04-01T03:46:57.1103507Z [ERROR] and
2026-04-01T03:46:57.1103717Z [ERROR] +-com.google.cloud:google-cloud-nio:0.128.14
2026-04-01T03:46:57.1103976Z [ERROR] +-com.google.cloud:google-cloud-storage:2.64.2-SNAPSHOT
2026-04-01T03:46:57.1104824Z [ERROR] +-com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.18.2 (managed) <-- com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.18.2
2026-04-01T03:46:57.1105436Z [ERROR] +-com.fasterxml.jackson.core:jackson-core:2.18.2 (managed) <-- com.fasterxml.jackson.core:jackson-core:2.18.2
2026-04-01T03:46:57.1105551Z [ERROR] and
2026-04-01T03:46:57.1105751Z [ERROR] +-com.google.cloud:google-cloud-nio:0.128.14
2026-04-01T03:46:57.1106015Z [ERROR] +-com.google.cloud:google-cloud-storage:2.64.2-SNAPSHOT
2026-04-01T03:46:57.1106842Z [ERROR] +-com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.18.2 (managed) <-- com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.18.2
2026-04-01T03:46:57.1107444Z [ERROR] +-com.fasterxml.jackson.core:jackson-core:2.18.2 (managed) <-- com.fasterxml.jackson.core:jackson-core:2.18.2
2026-04-01T03:46:57.1107651Z [ERROR] and
2026-04-01T03:46:57.1107846Z [ERROR] +-com.google.cloud:google-cloud-nio:0.128.14
2026-04-01T03:46:57.1108100Z [ERROR] +-com.google.cloud:google-cloud-storage:2.64.2-SNAPSHOT
2026-04-01T03:46:57.1108744Z [ERROR] +-com.fasterxml.jackson.core:jackson-databind:2.18.2 (managed) <-- com.fasterxml.jackson.core:jackson-databind:2.18.2
2026-04-01T03:46:57.1109422Z [ERROR] +-com.fasterxml.jackson.core:jackson-core:2.18.2 (managed) <-- com.fasterxml.jackson.core:jackson-core:2.18.2
2026-04-01T03:46:57.1109532Z [ERROR] and
2026-04-01T03:46:57.1109726Z [ERROR] +-com.google.cloud:google-cloud-nio:0.128.14
2026-04-01T03:46:57.1109986Z [ERROR] +-com.google.cloud:google-cloud-storage:2.64.2-SNAPSHOT
2026-04-01T03:46:57.1110731Z [ERROR] +-com.google.http-client:google-http-client-jackson2:2.1.0 (managed) <-- com.google.http-client:google-http-client-jackson2:2.1.0
2026-04-01T03:46:57.1111325Z [ERROR] +-com.fasterxml.jackson.core:jackson-core:2.18.2 (managed) <-- com.fasterxml.jackson.core:jackson-core:2.18.2
2026-04-01T03:46:57.1111447Z [ERROR] and
2026-04-01T03:46:57.1111639Z [ERROR] +-com.google.cloud:google-cloud-nio:0.128.14
2026-04-01T03:46:57.1111888Z [ERROR] +-com.google.cloud:google-cloud-storage:2.64.2-SNAPSHOT
2026-04-01T03:46:57.1112930Z [ERROR] +-io.opentelemetry.contrib:opentelemetry-gcp-resources:1.45.0-alpha (managed) <-- io.opentelemetry.contrib:opentelemetry-gcp-resources:1.37.0-alpha
2026-04-01T03:46:57.1113642Z [ERROR] +-com.fasterxml.jackson.core:jackson-core:2.18.2 [runtime] (managed) <-- com.fasterxml.jackson.core:jackson-core:2.18.3 [runtime]
2026-04-01T03:46:57.1113751Z [ERROR] ]
2026-04-01T03:46:57.1113877Z [ERROR] -> [Help 1]

=> #12351

@suztomo
suztomoforce-pushed the migrate-java-storage-nio branch from 3e1dbc5 to d27d0beCompareApril 1, 2026 14:58
@suztomo

suztomo commented Apr 1, 2026

Copy link
Copy Markdown
MemberAuthor

ci / gapic-libraries-bom failed.

2026-04-01T15:13:51.8367470Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project grpc-google-cloud-ces-v1beta: Compilation failure
2026-04-01T15:13:51.8368951Z [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-ces/grpc-google-cloud-ces-v1beta/src/main/java/com/google/cloud/ces/v1beta/EvaluationServiceGrpc.java:[3578,54] incompatible types: inference variable ResponseT has incompatible bounds
2026-04-01T15:13:51.8369309Z [ERROR] equality constraints: ReqT,RespT,com.google.longrunning.Operation
2026-04-01T15:13:51.8369668Z [ERROR] lower bounds: com.google.cloud.ces.v1beta.GenerateEvaluationRequest
2026-04-01T15:13:51.8369783Z [ERROR] -> [Help 1]
2026-04-01T15:13:51.8369884Z [ERROR] 

Retrying.

@suztomo

Copy link
Copy Markdown
MemberAuthor

Got versions.txt conflict.

b/477663567
Skipping the checkstyle plugin in google-cloud-nio-examples and google-cloud-nio-retrofit modules
because the plugin was not running in the modules in googleapis/java-storage-nio.
@suztomo
suztomo merged commit b194801 into mainApr 1, 2026
117 of 118 checks passed
@suztomo
suztomo deleted the migrate-java-storage-nio branch April 1, 2026 19:03
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@suztomo@chingor13@renovate-bot@JoeWang1127@sydney-munro@tronto20@BenWhitehead@danielduhh@diegomarquezp@maroth96@mpeddada1