Skip to content

Add support for customer-supplied encryption keys - #1236

Merged
mziccard merged 2 commits into
googleapis:masterfrom
mziccard:storage-encryption-key
Sep 13, 2016
Merged

Add support for customer-supplied encryption keys#1236
mziccard merged 2 commits into
googleapis:masterfrom
mziccard:storage-encryption-key

Conversation

@mziccard

Copy link
Copy Markdown
Contributor

This fixes#1037

@mziccardmziccard added the api: storage Issues related to the Cloud Storage API. label Sep 9, 2016
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2016
@mziccard

Copy link
Copy Markdown
ContributorAuthor

/cc @lesv

(I'll add some more tests to avoid this coverage drop)

@lesv

lesv commented Sep 9, 2016

Copy link
Copy Markdown
Contributor

LGTM - Thanks for this! Ping and I'll read the additional tests.

@mziccard
mziccardforce-pushed the storage-encryption-key branch from 0a2e63f to b0b6aa0CompareSeptember 12, 2016 14:03
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.08%) to 84.985% when pulling b0b6aa0 on mziccard:storage-encryption-key into 4d5a86c on GoogleCloudPlatform:master.

@mziccard

Copy link
Copy Markdown
ContributorAuthor

@lesv I rebased on top of master and added more coverage.

@lesv

lesv commented Sep 12, 2016

Copy link
Copy Markdown
Contributor

LOL - coveralls says it decreased.

@lesv

lesv commented Sep 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

@mziccard
mziccard merged commit 470d948 into googleapis:masterSep 13, 2016
github-actionsBot pushed a commit that referenced this pull request Jun 21, 2022
github-actionsBot pushed a commit that referenced this pull request Sep 15, 2022
🤖 I have created a release *beep* *boop*
---
## [2.3.8](googleapis/java-automl@v2.3.7...v2.3.8) (2022-09-09)
### Dependencies
* Update dependency com.google.cloud:google-cloud-core to v2.8.11 ([#1234](googleapis/java-automl#1234)) ([810774b](googleapis/java-automl@810774b))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1235](googleapis/java-automl#1235)) ([c839ade](googleapis/java-automl@c839ade))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
* feat: next release from main branch is 3.14.0
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
* fix: Make derived classes of Credential Source public
* fix: Lint
* move nested public class outside
* make CredentialSource public
* Rename CredentialSource to ExternalAccountCredentialSource
* fix format
* Move ExternalAccountCredentialSource back to ExternalAccountCredential
* Fix comment
* optimize imports
* chore(deps): update dependency com.google.auto.service:auto-service-annotations to v1.1.1 (#1253)
Co-authored-by: Lawrence Qiu <lqiu96@gmail.com>
---------
Co-authored-by: aeitzman <12433791+aeitzman@users.noreply.github.com>
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Lawrence Qiu <lqiu96@gmail.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
* feat: next release from main branch is 3.14.0
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
* fix: Make derived classes of Credential Source public
* fix: Lint
* move nested public class outside
* make CredentialSource public
* Rename CredentialSource to ExternalAccountCredentialSource
* fix format
* Move ExternalAccountCredentialSource back to ExternalAccountCredential
* Fix comment
* optimize imports
* chore(deps): update dependency com.google.auto.service:auto-service-annotations to v1.1.1 (#1253)
Co-authored-by: Lawrence Qiu <lqiu96@gmail.com>
---------
Co-authored-by: aeitzman <12433791+aeitzman@users.noreply.github.com>
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
Co-authored-by: Mend Renovate <bot@renovateapp.com>
Co-authored-by: Lawrence Qiu <lqiu96@gmail.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
Source-Link: https://togithub.com/googleapis/synthtool/commit/1fd6dff029bb3d873a4780e616388f802f086907
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ad9cabee4c022f1aab04a71332369e0c23841062124818a4490f73337f790337
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
🤖 I have created a release *beep* *boop*
---
## [1.120.11](googleapis/java-pubsub@v1.120.10...v1.120.11) (2022-08-06)
### Bug Fixes
* fix dependency declaration to properly include runtime scope ([#1238](googleapis/java-pubsub#1238)) ([e9a4ce5](googleapis/java-pubsub@e9a4ce5))
### Dependencies
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1235](googleapis/java-pubsub#1235)) ([e2af6c3](googleapis/java-pubsub@e2af6c3))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1236](googleapis/java-pubsub#1236)) ([399e8d7](googleapis/java-pubsub@399e8d7))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 1, 2026
🤖 I have created a release *beep* *boop*
---
## [1.120.11](googleapis/java-pubsub@v1.120.10...v1.120.11) (2022-08-06)
### Bug Fixes
* fix dependency declaration to properly include runtime scope ([#1238](googleapis/java-pubsub#1238)) ([65094ed](googleapis/java-pubsub@65094ed))
### Dependencies
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1235](googleapis/java-pubsub#1235)) ([631fc03](googleapis/java-pubsub@631fc03))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1236](googleapis/java-pubsub#1236)) ([2b3f5c0](googleapis/java-pubsub@2b3f5c0))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
…2.0 (googleapis#1236)
* chore(deps): update dependency com.google.cloud:libraries-bom to v25.2.0
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support customer-supplied encryption keys in Storage

4 participants

@mziccard@lesv@coveralls@googlebot