Skip to content

Revert "feat(gapic-generator): Add NullMarked annotation to generated classes" - #13573

Merged
zhumin8 merged 1 commit into
mainfrom
revert-13517-feat/jspecify-nullmarked
Jun 29, 2026
Merged

Revert "feat(gapic-generator): Add NullMarked annotation to generated classes"#13573
zhumin8 merged 1 commit into
mainfrom
revert-13517-feat/jspecify-nullmarked

Conversation

@zhumin8

@zhumin8zhumin8 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Reverts #13517

Fixes#13555

@zhumin8
zhumin8 requested review from a team as code ownersJune 29, 2026 19:46
@zhumin8zhumin8 mentioned this pull request Jun 29, 2026
Closed
gemini-code-assist[bot]
gemini-code-assistBot reviewed Jun 29, 2026
View reviewed changes

@gemini-code-assistgemini-code-assistBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @NullMarked annotation and its associated org.jspecify:jspecify dependency from the GAPIC generator, generated Java client libraries, stub classes, resource names, and build configuration files (such as pom.xml and java_gapic.bzl). Golden test files have also been updated to reflect these changes. I have no feedback to provide as there are no review comments.

@sonarqubecloud

sonarqubecloudBot commented Jun 29, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud

sonarqubecloudBot commented Jun 29, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhumin8
zhumin8 enabled auto-merge (squash) June 29, 2026 20:16
@zhumin8
zhumin8 merged commit 7bb3c35 into mainJun 29, 2026
286 of 294 checks passed
@zhumin8
zhumin8 deleted the revert-13517-feat/jspecify-nullmarked branch June 29, 2026 20:30
lqiu96 pushed a commit that referenced this pull request Jun 30, 2026
@zhumin8@lqiu96
Revert "feat(gapic-generator): Add NullMarked annotation to generated…
4462447
… classes" (#13573)
Reverts #13517Fixes#13555
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqiu96lqiu96lqiu96 approved these changes
+1 more reviewer
@gemini-code-assistgemini-code-assist[bot]gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Librarian generate diff check failed on main branch

2 participants

@zhumin8@lqiu96