Skip to content

ci(showcase): use separate filter job for version check - #13770

Merged
lqiu96 merged 2 commits into
mainfrom
investigate-check-version-ci
Jul 14, 2026
Merged

ci(showcase): use separate filter job for version check#13770
lqiu96 merged 2 commits into
mainfrom
investigate-check-version-ci

Conversation

@lqiu96

@lqiu96lqiu96 commented Jul 14, 2026•
edited
Loading

Copy link
Copy Markdown
Member

The check-version job in showcase is not running in PRs that do not modify the specific paths. Update the job to use a filter job to skip the job on non-relevant PRs.

Example: #13558

@gemini-code-assist

gemini-code-assistBot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@lqiu96
lqiu96 requested a review from jinseopkim0July 14, 2026 17:34
@lqiu96lqiu96 assigned blakeli0 and unassigned blakeli0Jul 14, 2026
@lqiu96
lqiu96 requested a review from blakeli0July 14, 2026 17:34
@lqiu96
lqiu96 marked this pull request as ready for review July 14, 2026 17:34
@lqiu96
lqiu96 requested review from a team as code ownersJuly 14, 2026 17:34
@lqiu96
lqiu96 enabled auto-merge (squash) July 14, 2026 17:35
blakeli0
blakeli0 approved these changes Jul 14, 2026
View reviewed changes

@blakeli0blakeli0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this check have to be required? @zhumin8

Separately, can we use one version as source of truth? It seems that we have a showcase version in pom and a showcase commitish in librarian.yaml. This could cause inconsistency if they are not in sync.

@lqiu96
lqiu96 merged commit a90b8df into mainJul 14, 2026
206 checks passed
@lqiu96
lqiu96 deleted the investigate-check-version-ci branch July 14, 2026 19:28
@zhumin8

zhumin8 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

This could cause inconsistency if they are not in sync.

Exactly why we need this test (for now).

can we use one version as source of truth?

Sure. It be great if the showcase version in pom can source from librarian.yaml and keep that as source of truth.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0blakeli0blakeli0 approved these changes
@jinseopkim0jinseopkim0Awaiting requested review from jinseopkim0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lqiu96@zhumin8@blakeli0