Uh oh!
There was an error while loading. Please reload this page.
chore(ci): update expected flattened dependencies - #13938
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates various dependency versions in the .kokoro/java-storage-expected-flattened-dependencies.txt file, including updates to Google Cloud Storage, GRPC, Guava, Protobuf, and Conscrypt libraries. I have no feedback to provide as there are no review comments.
f28aa8a to
cca5a14Compare6d537f0 to
8a36a8dCompare8a36a8d to
7095858Compare
|
|
blakeli0
left a comment
There was a problem hiding this comment.
I think we should evaluate if this check still provides value. IIRC, there was a bug in the flatten plugin, so it was created to test the flatten plugin. But we should not test our build dependencies, the same as that we don't test other Maven plugins such as maven deploy or formatter.
The "java-shared-config downstream (dependencies) / flatten-plugin-check" is currently failing on release PR #13934
It passes on this PR that updates kokoro/java-storage-expected-flattened-dependencies.txt, accounting for recent version changes (#13693, #13799, #13842, #13853, #13854, #13875, #13876, #13877).