Uh oh!
There was an error while loading. Please reload this page.
add Publisher.Settings - #1515
Closed
pongad wants to merge 2 commits into
Closed
Conversation
This class is used to configure Publisher. User-visible options are made public. Options that should be automatically populated, like user credentials, are left package-private for now.
coveralls
commented
Jan 9, 2017
Changes Unknown when pulling 2beb34e on pongad:publisher-settings into ** on GoogleCloudPlatform:pubsub-hp**. |
coveralls
commented
Jan 9, 2017
Changes Unknown when pulling 95c9d40 on pongad:publisher-settings into ** on GoogleCloudPlatform:pubsub-hp**. |
pongad
commented
Jan 10, 2017
pongad
left a comment
ContributorAuthor
There was a problem hiding this comment.
@garrettjonesgoogle I think I got this mostly right, but I'm completely unfamiliar with the handwritten option classes. PTAL.
| maxBundleMessages = builder.bundlingSettings.getElementCountThreshold(); | ||
| maxBundleBytes = builder.bundlingSettings.getRequestByteThreshold(); | ||
| maxBundleDuration = builder.bundlingSettings.getDelayThreshold(); | ||
| PublisherImpl(String topic, PubSubOptions psOptions, Settings settings) throws IOException { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
coveralls
commented
Jan 10, 2017
Changes Unknown when pulling 73074a5 on pongad:publisher-settings into ** on GoogleCloudPlatform:pubsub-hp**. |
| maxBundleMessages = builder.bundlingSettings.getElementCountThreshold(); | ||
| maxBundleBytes = builder.bundlingSettings.getRequestByteThreshold(); | ||
| maxBundleDuration = builder.bundlingSettings.getDelayThreshold(); | ||
| PublisherImpl(String topic, PubSubOptions psOptions, Settings settings) throws IOException { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
garrettjonesgoogle
commented
Jan 17, 2017
Contributor
Is this obsolete or does it need to be rewritten? |
pongad
commented
Jan 17, 2017
ContributorAuthor
@garrettjonesgoogle Thanks for pointing this out. This is superseded by us deleting all the hand written parts. |
meltsufin pushed a commit
that referenced
this pull request
Dec 22, 2025
🤖 I have created a release *beep* *boop* --- ## [3.15.16](https://togithub.com/googleapis/java-logging/compare/v3.15.15...v3.15.16) (2024-01-25) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.32.0 ([#1511](https://togithub.com/googleapis/java-logging/issues/1511)) ([e2f574c](https://togithub.com/googleapis/java-logging/commit/e2f574caa0b8c2a2cdb3b186fbf2d599d6ef4c2b)) * Enable v2.LogEntry Protobufs converter functions ([#1509](https://togithub.com/googleapis/java-logging/issues/1509)) ([9ef4d90](https://togithub.com/googleapis/java-logging/commit/9ef4d9048b1ecdc887ebc9cb4898a4bfe3f6c154)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.22.0 ([#1510](https://togithub.com/googleapis/java-logging/issues/1510)) ([b40e846](https://togithub.com/googleapis/java-logging/commit/b40e8465590dadec7c9ff26eb27e92c16b059489)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.23.0 ([#1518](https://togithub.com/googleapis/java-logging/issues/1518)) ([30ba9ed](https://togithub.com/googleapis/java-logging/commit/30ba9ed687f5469d36138a138f68cd998cf60b53)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit
that referenced
this pull request
Jan 6, 2026
* chore: Remove PR rate limit in renovate.json * Update renovate.json
chingor13 pushed a commit
that referenced
this pull request
Jan 22, 2026
suztomo pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 11, 2026
🤖 I have created a release *beep* *boop* --- ## [3.15.16](https://togithub.com/googleapis/java-logging/compare/v3.15.15...v3.15.16) (2024-01-25) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.32.0 ([googleapis#1511](https://togithub.com/googleapis/java-logging/issues/1511)) ([078d2ff](https://togithub.com/googleapis/java-logging/commit/078d2ffea532d020879f7d50d6d921086c70a220)) * Enable v2.LogEntry Protobufs converter functions ([googleapis#1509](https://togithub.com/googleapis/java-logging/issues/1509)) ([f74a545](https://togithub.com/googleapis/java-logging/commit/f74a5451622c2192286790e30daa60ee01112548)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.22.0 ([googleapis#1510](https://togithub.com/googleapis/java-logging/issues/1510)) ([12ac218](https://togithub.com/googleapis/java-logging/commit/12ac218d8dd1457c66de56eb8a55569665906c5a)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.23.0 ([googleapis#1518](https://togithub.com/googleapis/java-logging/issues/1518)) ([14e4aff](https://togithub.com/googleapis/java-logging/commit/14e4affcb26e96333b29f965f7b339ed2fd05db9)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
lqiu96 pushed a commit
that referenced
this pull request
Mar 20, 2026
* chore: Remove PR rate limit in renovate.json * Update renovate.json
suztomo pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Mar 23, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit
that referenced
this pull request
Mar 30, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 pushed a commit
that referenced
this pull request
Apr 1, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit
that referenced
this pull request
Apr 29, 2026
…o v1.123.5 (#1515) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.5 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit
that referenced
this pull request
May 1, 2026
…o v1.123.5 (#1515) * chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.5 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class is used to configure Publisher.
User-visible options are made public.
Options that should be automatically populated,
like user credentials,
are left package-private for now.
Tests for input validation for BundlingSettings
and FlowController are removed.
They should be moved to gax instead.
googleapis/gax-java#168