Skip to content

make Publisher uses RetrySettings - #1538

Merged
pongad merged 3 commits into
googleapis:pubsub-rmfrom
pongad:publisher-retry
Jan 18, 2017
Merged

make Publisher uses RetrySettings#1538
pongad merged 3 commits into
googleapis:pubsub-rmfrom
pongad:publisher-retry

Conversation

@pongad

@pongadpongad commented Jan 16, 2017

Copy link
Copy Markdown
Contributor

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2017
pongad
pongad commented Jan 16, 2017
View reviewed changes
Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java Outdated
.setMaxRetryDelay(Duration.millis(Long.MAX_VALUE))
.setInitialRpcTimeout(DEFAULT_REQUEST_TIMEOUT)
.setRpcTimeoutMultiplier(2)
.setMaxRpcTimeout(DEFAULT_REQUEST_TIMEOUT)

This comment was marked as spam.

Sign in to view

@coveralls

coveralls commented Jan 16, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 83.113% when pulling 9e301d1 on pongad:publisher-retry into 19acb03 on GoogleCloudPlatform:pubsub-rm.

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 17, 2017
View reviewed changes
Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java Outdated
.build();
static final RetrySettings DEFAULT_RETRY_SETTINGS =
RetrySettings.newBuilder()
.setTotalTimeout(MIN_TOTAL_TIMEOUT)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherImpl.java
}

@Override
public long getMaxBundleMessages() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java Outdated
@@ -150,14 +151,24 @@ public final class Builder {
static final long DEFAULT_MAX_BUNDLE_BYTES = 1000L; // 1 kB
static final Duration DEFAULT_MAX_BUNDLE_DURATION = new Duration(1); // 1ms
static final Duration DEFAULT_REQUEST_TIMEOUT = new Duration(10 * 1000); // 10 seconds

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java Outdated
@@ -150,14 +151,24 @@ public final class Builder {
static final long DEFAULT_MAX_BUNDLE_BYTES = 1000L; // 1 kB
static final Duration DEFAULT_MAX_BUNDLE_DURATION = new Duration(1); // 1ms

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Jan 18, 2017

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle PTAL

@coveralls

coveralls commented Jan 18, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0008%) to 83.114% when pulling 7b3a578 on pongad:publisher-retry into 19acb03 on GoogleCloudPlatform:pubsub-rm.

@garrettjonesgoogle

garrettjonesgoogle commented Jan 18, 2017

Copy link
Copy Markdown
Contributor

LGTM - but put the failure here on your list to investigate: https://travis-ci.org/GoogleCloudPlatform/google-cloud-java/jobs/192903764 (it is a pubsub failure; it seems intermittent since 3 builds passed, this one failed)

@pongad

pongad commented Jan 18, 2017

Copy link
Copy Markdown
ContributorAuthor

As discussed, we can merge to pubsub-hp, but we'll definitely hold off merging to master until we fix the flakes.

@pongad
pongad merged commit 5ee13e7 into googleapis:pubsub-rmJan 18, 2017
@pongad
pongad deleted the publisher-retry branch January 18, 2017 23:18
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@gcf-owl-bot
feat: Add an API method for reordering firewall policies (#1538)
9cd6b96
* feat: Add an API method for reordering firewall policies
PiperOrigin-RevId: 607015517
Source-Link: googleapis/googleapis@c43e216
Source-Link: https://github.com/googleapis/googleapis-gen/commit/71c27adc96b0c80093b4a413815bd93943196bb2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
@release-please
chore(main): release 0.132.19-alpha (#1538)
e6e2935
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@release-please
chore(main): release 2.21.1-SNAPSHOT (#1538)
2e39265
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@gcf-owl-bot
feat: Add an API method for reordering firewall policies (googleapis#…
f77a5f8
…1538)
* feat: Add an API method for reordering firewall policies
PiperOrigin-RevId: 607015517
Source-Link: googleapis/googleapis@c43e216
Source-Link: https://github.com/googleapis/googleapis-gen/commit/71c27adc96b0c80093b4a413815bd93943196bb2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzFjMjdhZGM5NmIwYzgwMDkzYjRhNDEzODE1YmQ5Mzk0MzE5NmJiMiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
@release-please
chore(main): release 0.132.19-alpha (#1538)
874db97
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@gcf-owl-bot
chore: README template fix in google-cloud-java (#1785) (#1538)
e161e93
Source-Link: googleapis/synthtool@43c709a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:3387f93d4577788512112ff69ddab746ae9192ddd9f13cfd175ef310d62d7d30
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
@gcf-owl-bot
chore: README template fix in google-cloud-java (#1785) (#1538)
c841b9c
Source-Link: googleapis/synthtool@43c709a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:3387f93d4577788512112ff69ddab746ae9192ddd9f13cfd175ef310d62d7d30
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@renovate-bot
deps: update dependency org.graalvm.buildtools:native-maven-plugin to…
c9b0943
… v0.9.19 (googleapis#1538)
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@release-please
chore(main): release 2.17.0 (googleapis#1516)
9007887
🤖 I have created a release *beep* *boop*
---
## [2.17.0](https://togithub.com/googleapis/java-bigtable/compare/v2.16.0...v2.17.0) (2022-12-07)
### Features
* Add a query paginator ([googleapis#1530](https://togithub.com/googleapis/java-bigtable/issues/1530)) ([0eebc14](https://togithub.com/googleapis/java-bigtable/commit/0eebc14218f05675a97cd19202edc1499c980e72))
* Add test proxy to java-bigtable client ([googleapis#1498](https://togithub.com/googleapis/java-bigtable/issues/1498)) ([3a7a408](https://togithub.com/googleapis/java-bigtable/commit/3a7a40871ce07dbf9192f5d3f7de3d9981622ef5))
* Implement cross-project table restore ([googleapis#1536](https://togithub.com/googleapis/java-bigtable/issues/1536)) ([418a5d4](https://togithub.com/googleapis/java-bigtable/commit/418a5d4a5362ef213dce2dae767bc841bcd77df4))
* Next release from main branch is 2.17.0 ([googleapis#1514](https://togithub.com/googleapis/java-bigtable/issues/1514)) ([e480dec](https://togithub.com/googleapis/java-bigtable/commit/e480dec93b073c7010bf49e4981362805af90f12))
### Dependencies
* Update dependency com.google.cloud:google-cloud-monitoring-bom … ([googleapis#1531](https://togithub.com/googleapis/java-bigtable/issues/1531)) ([927d57b](https://togithub.com/googleapis/java-bigtable/commit/927d57b094e8edf99c39dc50814c318f0f62ff75))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([googleapis#1539](https://togithub.com/googleapis/java-bigtable/issues/1539)) ([96496bb](https://togithub.com/googleapis/java-bigtable/commit/96496bb2f5fa0929cdfbfa950ef8572dd1ea5b0a))
* Update dependency kr.motd.maven:os-maven-plugin to v1.7.1 ([googleapis#1518](https://togithub.com/googleapis/java-bigtable/issues/1518)) ([5ba0bcd](https://togithub.com/googleapis/java-bigtable/commit/5ba0bcdcf0b794cc7ed214498f789700f1af432c))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.19 ([googleapis#1537](https://togithub.com/googleapis/java-bigtable/issues/1537)) ([22f2cc5](https://togithub.com/googleapis/java-bigtable/commit/22f2cc55d7f1b901d6dd398f8bd1c7a7c1b2312e))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.19 ([googleapis#1538](https://togithub.com/googleapis/java-bigtable/issues/1538)) ([c9b0943](https://togithub.com/googleapis/java-bigtable/commit/c9b0943c4aab15267547ab3eece05249c9d92b1b))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@garrettjonesgooglegarrettjonesgooglegarrettjonesgoogle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@garrettjonesgooglegarrettjonesgoogle

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad@coveralls@garrettjonesgoogle@googlebot