Skip to content

do not expose Service - #1553

Merged
pongad merged 1 commit into
googleapis:pubsub-hpfrom
pongad:de-service
Jan 25, 2017
Merged

do not expose Service#1553
pongad merged 1 commit into
googleapis:pubsub-hpfrom
pongad:de-service

Conversation

@pongad

@pongadpongad commented Jan 20, 2017

Copy link
Copy Markdown
Contributor

I'm not sure how ready this PR is. The general logic is to hide the implementation in a subclass then create a delegator. If the approach looks fine to you, I'll go ahead and document the methods.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 20, 2017
@pongad

pongad commented Jan 24, 2017

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle Please take a look. If possible, I'd like to merge this ASAP, since everything we do will conflict with this change.

@coveralls

coveralls commented Jan 24, 2017

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 83.081% when pulling e0493ba on pongad:de-service into c68968b on GoogleCloudPlatform:pubsub-hp.

@garrettjonesgoogle

garrettjonesgoogle commented Jan 24, 2017

Copy link
Copy Markdown
Contributor

It's hard to figure out what has changed and what has moved - can you point me to the points in the PR that need to actually be considered?

@pongad

pongad commented Jan 24, 2017

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle Essentially, all fields (non static ones) and all methods are moved into the inner SubscriberImpl class. SubscriberImpl still extends AbstractService so that we can the methods we want. The Subscriber class just re-declare methods in SubscriberImpl. It also re-declares Service.State and Service.Listener classes and translate between the original and the redeclaration.

pongad
pongad commented Jan 24, 2017
View reviewed changes
Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
logger.debug("Starting subscriber group.");
startStreamingConnections();
notifyStarted();
public enum State {

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
TERMINATED
}

public abstract static class SubscriberListener {

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle

garrettjonesgoogle commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

LGTM

@pongad
pongad merged commit f91c809 into googleapis:pubsub-hpJan 25, 2017
@pongad
pongad deleted the de-service branch January 25, 2017 01:30
github-actionsBot pushed a commit to yoshi-code-bot/google-cloud-java that referenced this pull request Nov 8, 2022
@gcf-owl-bot@chingor13
chore(java): add a note in README for migrated split repos (googleapi…
7b8aa8b
…s#1687) (googleapis#1553)
* chore(java): add a note in README for migrated split repos
Disable renovate bot and flaky bot for split repositories
that have moved to the Java monorepo.
The Java monorepo will pass the "monorepo=True" parameter
to java.common_templates method in its owlbot.py files so that
the migration note will not appear in the README in the monorepo.
Co-authored-by: Jeff Ching <chingor@google.com>
Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@gcf-owl-bot
fix(deps): Update the Java code generator (gapic-generator-java) to 2…
15b05fc
….37.0 (#1553)
* fix(deps): Update the Java code generator (gapic-generator-java) to 2.37.0
PiperOrigin-RevId: 611816371
Source-Link: googleapis/googleapis@2a40f63
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d30ff0767777b381fb1617f67a90e3abd3bdc6dc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDMwZmYwNzY3Nzc3YjM4MWZiMTYxN2Y2N2E5MGUzYWJkM2JkYzZkYyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@release-please
chore(main): release 3.16.1 (#1554)
e47f10d
🤖 I have created a release *beep* *boop*
---
## [3.16.1](https://togithub.com/googleapis/java-logging/compare/v3.16.0...v3.16.1) (2024-03-07)
### Bug Fixes
* **deps:** Update the Java code generator (gapic-generator-java) to 2.37.0 ([#1553](https://togithub.com/googleapis/java-logging/issues/1553)) ([15b05fc](https://togithub.com/googleapis/java-logging/commit/15b05fc4a8e6c4069414110b749525082821e509))
### Dependencies
* Update dependency com.google.cloud:sdk-platform-java-config to v3.27.0 ([#1552](https://togithub.com/googleapis/java-logging/issues/1552)) ([6c5464d](https://togithub.com/googleapis/java-logging/commit/6c5464d1c5a74962fcd459a1e03282747e148a44))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@release-please
chore(main): release 2.21.2 (#1553)
e368dc5
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@gcf-owl-bot
fix(deps): Update the Java code generator (gapic-generator-java) to 2…
12bd21f
….37.0 (googleapis#1553)
* fix(deps): Update the Java code generator (gapic-generator-java) to 2.37.0
PiperOrigin-RevId: 611816371
Source-Link: googleapis/googleapis@2a40f63
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d30ff0767777b381fb1617f67a90e3abd3bdc6dc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDMwZmYwNzY3Nzc3YjM4MWZiMTYxN2Y2N2E5MGUzYWJkM2JkYzZkYyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@release-please
chore(main): release 3.16.1 (googleapis#1554)
2645473
🤖 I have created a release *beep* *boop*
---
## [3.16.1](https://togithub.com/googleapis/java-logging/compare/v3.16.0...v3.16.1) (2024-03-07)
### Bug Fixes
* **deps:** Update the Java code generator (gapic-generator-java) to 2.37.0 ([googleapis#1553](https://togithub.com/googleapis/java-logging/issues/1553)) ([12bd21f](https://togithub.com/googleapis/java-logging/commit/12bd21ffab34e85a4e4af9f1f65b9afb570a7a14))
### Dependencies
* Update dependency com.google.cloud:sdk-platform-java-config to v3.27.0 ([googleapis#1552](https://togithub.com/googleapis/java-logging/issues/1552)) ([0b94696](https://togithub.com/googleapis/java-logging/commit/0b946963f15565ef4438afafa6481656adfeab7d))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot
deps: update dependency node to v22 (#1553)
fa07abb
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@renovate-bot
deps: update dependency node to v22 (#1553)
0276904
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot@gcf-owl-bot
chore(deps): update dependency com.google.cloud:google-cloud-pubsub t…
3f25646
…o v1.123.9 (#1553)
* chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot@gcf-owl-bot
chore(deps): update dependency com.google.cloud:google-cloud-pubsub t…
64f69ce
…o v1.123.9 (#1553)
* chore(deps): update dependency com.google.cloud:google-cloud-pubsub to v1.123.9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@garrettjonesgooglegarrettjonesgoogle

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad@coveralls@garrettjonesgoogle@googlebot