Make class com.google.cloud.ServiceOptions$Builder public

[rborer]

Hi,

I'm trying to use BigQuery client from clojure. Due to a very old JVM bug, the class com.google.cloud.ServiceOptions$Builder need to be flagged public to make configuration methods callable from clojure (clojure uses reflection).

Due to this bug, the following piece of code throws an exception:

(-> (BigQueryOptions/newBuilder)
(.setProjectId project-id))

=>

IllegalArgumentException Can't call public method of non-public class: public com.google.cloud.ServiceOptions$Builder com.google.cloud.ServiceOptions$Builder.setProjectId(java.lang.String) clojure.lang.Reflector.invokeMatchingMethod (Reflector.java:88)

As replied on the corresponding StackOverflow thread there are work-arounds but they are non-trivial to implement.

Thanks in advance to consider this patch.

Cheers,
Reynald

[coveralls]

Changes Unknown when pulling d590a73 on rborer:public-serviceoptions-builder into ** on GoogleCloudPlatform:master**.

[garrettjonesgoogle]

This was written before I started work on this project, and I can't figure out what the advantage is of having the Builder class be protected. I guess it's an attempt to prevent people from directly holding references to the ServiceOptions$Builder type? I can't figure out what kind of mistakes or inappropriate dependencies that would prevent.

@aozarov maybe you have some insight here?

[rborer]

maybe the purpose here was to prevent anyone to directly create an instance of this Builder class, but given that it's abstract I cannot figure out how one would be able to achieve that ;-)

[aozarov]

Change looks fine.

This class was "internal" as it is nasty from generics perspective and we wanted to force holding a
reference to it and using its API only via its much cleaner sub-classes. Not a big deal though.

[garrettjonesgoogle]

Thanks, @aozarov !

[rborer]

Thanks.