Skip to content

pubsub: make Subscriber logs less chatty - #1748

Merged
pongad merged 2 commits into
googleapis:masterfrom
pongad:subscriber-log-level
Mar 15, 2017
Merged

pubsub: make Subscriber logs less chatty#1748
pongad merged 2 commits into
googleapis:masterfrom
pongad:subscriber-log-level

Conversation

@pongad

@pongadpongad commented Mar 14, 2017

Copy link
Copy Markdown
Contributor

Also use text formatting so we don't unnecessarily allocate
Strings when not logging.

Fixes#1686.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2017
@pongadpongad changed the title logging: make Subscriber logs less chattypubsub: make Subscriber logs less chattyMar 14, 2017
@pongad
pubsub: make Subscriber logs less chatty
419708f
Also use text formatting so we don't unnecessarily allocate
Strings when not logging.
Fixes#1686.
@coveralls

coveralls commented Mar 14, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 419708f on pongad:subscriber-log-level into ** on GoogleCloudPlatform:master**.

garrettjonesgoogle
garrettjonesgoogle reviewed Mar 14, 2017
View reviewed changes
Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java
Instant expiration = now.plus(messageDeadlineSeconds * 1000);
logger.log(Level.INFO, "Received " + responseMessages.size() + " messages at " + now);
logger.log(
Level.FINER, "Received {0} messages at {1}", new Object[] {responseMessages.size(), now});

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java Outdated
+ ", padding: "
+ ackExpirationPadding);
Level.FINER,
"Running alarm sent outstanding acks, at time: {0}, with cutover time: {1}, padding {2}",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...e-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java Outdated
@Override
protected void doStart() {
logger.log(Level.INFO, "Starting subscriber.");
logger.log(Level.FINE, "Starting subscriber.");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lesv
lesv reviewed Mar 14, 2017
View reviewed changes

@lesvlesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree w/ Garrett here - one time things are fine at INFO; I've suggested some shorthand, feel free to ignore.

Comment thread...e-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java Outdated
@Override
protected void doStart() {
logger.log(Level.INFO, "Starting subscriber.");
logger.log(Level.FINE, "Starting subscriber.");

This comment was marked as spam.

Sign in to view

Comment thread...cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/StreamingSubscriberConnection.java Outdated
@Override
protected void doStart() {
logger.log(Level.INFO, "Starting subscriber.");
logger.log(Level.FINE, "Starting subscriber.");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/StreamingSubscriberConnection.java Outdated
@Override
public void onCompleted() {
logger.log(Level.INFO, "Streaming pull terminated successfully!");
logger.log(Level.FINE, "Streaming pull terminated successfully!");

This comment was marked as spam.

Sign in to view

@coveralls

coveralls commented Mar 15, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling a0628d2 on pongad:subscriber-log-level into ** on GoogleCloudPlatform:master**.

@pongad

pongad commented Mar 15, 2017

Copy link
Copy Markdown
ContributorAuthor

@lesv@garrettjonesgoogle PTAL

@garrettjonesgoogle

garrettjonesgoogle commented Mar 15, 2017

Copy link
Copy Markdown
Contributor

LGTM

@pongad
pongad merged commit d4be5e5 into googleapis:masterMar 15, 2017
@pongad
pongad deleted the subscriber-log-level branch March 15, 2017 03:08
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot@olavloite
deps: update dependency com.google.cloud:google-cloud-spanner-bom to …
b82ca1f
…v6.74.1 (googleapis#1748)
* deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.74.1
* chore: update priority name
---------
Co-authored-by: Knut Olav Løite <koloite@gmail.com>
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
93b6e07
…78.0 (#1748)
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
2dde15c
…78.0 (#1748)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@release-please
chore(main): release 1.125.4-SNAPSHOT (#1748)
1febfba
🤖 I have created a release *beep* *boop*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 1, 2026
@release-please
chore(main): release 1.125.4-SNAPSHOT (#1748)
8b4b37b
🤖 I have created a release *beep* *boop*
---
### Updating meta-information for bleeding-edge SNAPSHOT release.
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@renovate-bot
test(deps): update dependency com.google.cloud:google-cloud-conforman…
c9d47de
…ce-tests to v0.3.6 (googleapis#1748)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@lesvlesvlesv left review comments
@garrettjonesgooglegarrettjonesgooglegarrettjonesgoogle left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pongad@coveralls@garrettjonesgoogle@lesv@googlebot