Skip to content

Cloud logging logback appender - #2045

Merged
jabubake merged 17 commits into
googleapis:masterfrom
jabubake:cloud-logging-logback-adapter
May 23, 2017
Merged

Cloud logging logback appender#2045
jabubake merged 17 commits into
googleapis:masterfrom
jabubake:cloud-logging-logback-adapter

Conversation

@jabubake

@jabubakejabubake commented May 9, 2017

Copy link
Copy Markdown
Contributor

Adding logback support (via Slf4j surface) for google-cloud-logging

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 9, 2017
@jabubake

jabubake commented May 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@meltsufin , @gregw PTAL

@coveralls

coveralls commented May 10, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 46dc384 on jabubake:cloud-logging-logback-adapter into ** on GoogleCloudPlatform:master**.

@coveralls

coveralls commented May 10, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 0184291 on jabubake:cloud-logging-logback-adapter into ** on GoogleCloudPlatform:master**.

gregw
gregw reviewed May 10, 2017
View reviewed changes
Comment threadgoogle-cloud-contrib/google-cloud-logging-logback/README.md Outdated
<appender name="CLOUD" class="com.google.cloud.logging.contrib.LoggingAppender">
<level>DEBUG</level> <!-- Optional : default INFO -->
<log>application.log</log> <!-- Optional : default java.log -->
<enhancers>com.google.cloud.logging.TestLoggingEnhancer</enhancers> <!-- Optional -->

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-contrib/google-cloud-logging-logback/README.md Outdated
Add the appender to your [Logback configuration](https://logback.qos.ch/manual/configuration.html) `logback.xml`
```xml
<configuration>
<appender name="CLOUD" class="com.google.cloud.logging.contrib.LoggingAppender">

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/contrib/LoggingAppender.java Outdated
return MonitoredResourceUtil.getResource(projectId, resourceType);
}

List<LoggingEnhancer> getEnhancers() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

meltsufin
meltsufin reviewed May 10, 2017
View reviewed changes

@meltsufinmeltsufin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jisha for putting this together!

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/contrib/LoggingAppender.java Outdated
}

/**
* Sets the minimum logging level, defaults to INFO

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/contrib/LoggingAppender.java Outdated
List<LoggingEnhancer> enhancers = new ArrayList<>();
if (list != null) {
String[] items = list.split(",");
for (String e_name : items) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/contrib/LoggingAppender.java Outdated
/**
* Add extra labels using classes that implement {@link LoggingEnhancer}.
*
* @param enhancers list of enhancer classnames

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls

coveralls commented May 10, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 4348833 on jabubake:cloud-logging-logback-adapter into ** on GoogleCloudPlatform:master**.

@coveralls

coveralls commented May 11, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 8cd6b19 on jabubake:cloud-logging-logback-adapter into ** on GoogleCloudPlatform:master**.

@jabubake

jabubake commented May 12, 2017

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle PTAL

garrettjonesgoogle
garrettjonesgoogle reviewed May 16, 2017
View reviewed changes
Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
private String enhancers;

/**
* Batched logging requests get immediately flushed for logs at or above level.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
}

/**
* Sets the log filename, defaults to java.log.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
* Sets the name of the monitored resource (Optional).
*
* <p>Must be a <a href="https://cloud.google.com/logging/docs/api/v2/resource-list">supported</a>
* resource type. gae_app, gce_instance and container are auto-detected, defaults to "global"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
* <p>Must be a <a href="https://cloud.google.com/logging/docs/api/v2/resource-list">supported</a>
* resource type. gae_app, gce_instance and container are auto-detected, defaults to "global"
*
* @param resourceType name of monitored resource

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
*
* @param enhancers list of enhancer classnames (comma separated)
*/
public void setEnhancers(String enhancers) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-contrib/google-cloud-logging-logback/README.md Outdated
<!-- Optional : filter logs at or above a level -->
<filter class="ch.qos.logback.classic.filter.ThresholdFilter">
<level>INFO</level>
</filter>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-contrib/google-cloud-logging-logback/README.md Outdated
-----------

This library is usable, but not yet complete.
* Auto-reload of properties is not fully tested

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
super.stop();
}

protected Logging getLogging() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java Outdated
super.start();
}

protected String getProjectId() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread...le-cloud-logging-logback/src/main/java/com/google/cloud/logging/logback/LoggingAppender.java

/** Initialze and configure the cloud logging service. */
@Override
public synchronized void start() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@jabubake
Merge remote-tracking branch 'upstream/master' into cloud-logging-log…
0d55036
…back-adapter
@jabubake
updating mock framework
667a4d0
enhancers now individual xml elements
code cleanup based on review
@coveralls

coveralls commented May 17, 2017

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 667a4d0 on jabubake:cloud-logging-logback-adapter into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle

garrettjonesgoogle commented May 22, 2017

Copy link
Copy Markdown
Contributor

Everything looks good, except the versions need to be updated again - s/0.17.2/0.18.0/ and s/0.17.3-alpha-SNAPSHOT/0.18.1-alpha/SNAPSHOT/

@jabubake

jabubake commented May 23, 2017

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle done.

@garrettjonesgoogle

garrettjonesgoogle commented May 23, 2017

Copy link
Copy Markdown
Contributor

LGTM

@jabubake
jabubake merged commit ad54a73 into googleapis:masterMay 23, 2017
@jabubake
jabubake deleted the cloud-logging-logback-adapter branch May 23, 2017 19:01
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@jabubake
Cloud logging logback appender (#2045)
5a11507
 Logback support for google-cloud-logging
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026
@jabubake
Cloud logging logback appender (googleapis#2045)
6de2583
 Logback support for google-cloud-logging
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-trace to v2.62.0 (
c222938
googleapis#2045)
meltsufin pushed a commit that referenced this pull request May 2, 2026
@cloud-java-bot
chore: Update generation configuration at Wed Mar 19 02:29:06 UTC 2025 (
c161295
#2045)
* chore: Update generation configuration at Sat Mar 15 02:26:49 UTC 2025
* chore: Update generation configuration at Mon Mar 17 02:30:04 UTC 2025
* chore: Update generation configuration at Tue Mar 18 02:29:28 UTC 2025
* chore: Update generation configuration at Wed Mar 19 02:29:06 UTC 2025
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@igorbernstein2@gcf-owl-bot
feat: count row merging errors as internal errors (googleapis#2045)
68b8f0b
* feat: count row merging errors as internal errors
Currently they dont have a status associated and thus get counted as UNKOWN
Change-Id: Ida3470a0609f2e2ad51534eb3141db394af1dcdc
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* format
Change-Id: Iccb2a38b78e5f6c420cb1656887beebaecfa02d2
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@release-please
chore(main): release 2.31.0 (googleapis#2034)
335cddb
🤖 I have created a release *beep* *boop*
---
## [2.31.0](https://togithub.com/googleapis/java-bigtable/compare/v2.30.0...v2.31.0) (2024-01-12)
### Features
* Add a flag to add / remove routing cookie from callable chain ([googleapis#2032](https://togithub.com/googleapis/java-bigtable/issues/2032)) ([8d08406](https://togithub.com/googleapis/java-bigtable/commit/8d08406d1775cf4274ae712f75511043c2800001))
* Adding feature flags for routing cookie and retry info ([googleapis#2031](https://togithub.com/googleapis/java-bigtable/issues/2031)) ([450af14](https://togithub.com/googleapis/java-bigtable/commit/450af14068131c27fb42176bca779df67cf6e292))
* Count row merging errors as internal errors ([googleapis#2045](https://togithub.com/googleapis/java-bigtable/issues/2045)) ([68b8f0b](https://togithub.com/googleapis/java-bigtable/commit/68b8f0b9dacf631836377c62aa9723d06af73536))
* Enable feature flag when setting is enabled ([googleapis#2043](https://togithub.com/googleapis/java-bigtable/issues/2043)) ([29e67f2](https://togithub.com/googleapis/java-bigtable/commit/29e67f2f128027ee944e7f09ff1a5a575e611531))
* Handle retry info so client respect the delay server sets ([googleapis#2026](https://togithub.com/googleapis/java-bigtable/issues/2026)) ([96e6011](https://togithub.com/googleapis/java-bigtable/commit/96e60112db170f7f6615687436a0ca6814917552))
### Bug Fixes
* **deps:** Update the Java code generator (gapic-generator-java) to 2.31.0 ([googleapis#2044](https://togithub.com/googleapis/java-bigtable/issues/2044)) ([1c0b376](https://togithub.com/googleapis/java-bigtable/commit/1c0b3764058a9cc50c25650e231b448aed4555dc))
* Fix RetryInfo algorithm and tests ([googleapis#2041](https://togithub.com/googleapis/java-bigtable/issues/2041)) ([9fa2bd5](https://togithub.com/googleapis/java-bigtable/commit/9fa2bd56ceb0e797d92d67741442a37a53461abc))
### Dependencies
* Update dependency com.google.cloud:gapic-libraries-bom to v1.27.0 ([googleapis#2030](https://togithub.com/googleapis/java-bigtable/issues/2030)) ([9ee2f56](https://togithub.com/googleapis/java-bigtable/commit/9ee2f56ab74774dd35c2d8dc6a5628e75e8c3698))
* Update dependency com.google.truth.extensions:truth-proto-extension to v1.2.0 ([googleapis#2035](https://togithub.com/googleapis/java-bigtable/issues/2035)) ([ffd8af3](https://togithub.com/googleapis/java-bigtable/commit/ffd8af39afb770f8dc3ef6622942f2141a8141fc))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lesvlesvAwaiting requested review from lesv
3 more reviewers
@gregwgregwgregw left review comments
@garrettjonesgooglegarrettjonesgooglegarrettjonesgoogle left review comments
@meltsufinmeltsufinmeltsufin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jabubake@coveralls@garrettjonesgoogle@gregw@meltsufin@googlebot