Uh oh!
There was an error while loading. Please reload this page.
Convert all BigQuery deserialized enum types to StringEnumValue - #2128
Conversation
Introduces generalization of pattern for Storage/Datastore/Logging to simulate enum types with single data members. This appears to cover all cases in remaining Cloud APIs.
tcoffee-google
commented
Jun 8, 2017
Posting BigQuery for design review before converting remaining APIs. |
coveralls
commented
Jun 8, 2017
Changes Unknown when pulling 7aeab93 on tcoffee-google:string_enum_bigquery into ** on GoogleCloudPlatform:master**. |
| private StandardSQLTypeName equivalent; | ||
| LegacySQLTypeName(StandardSQLTypeName equivalent) { | ||
| LegacySQLTypeName setStandardType(StandardSQLTypeName equivalent) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
tcoffee-google
commented
Jun 9, 2017
@garrettjonesgoogle would you agree with the codacy-bot recommendation here? If so, I can retroactively change the previously published |
coveralls
commented
Jun 9, 2017
Changes Unknown when pulling 389bbdd on tcoffee-google:string_enum_bigquery into ** on GoogleCloudPlatform:master**. |
shinfan
commented
Jun 9, 2017
It would be nice to fix the codacy-bot suggestions... Those posts make the page very long and hard to scroll... |
garrettjonesgoogle
commented
Jun 9, 2017
@tcoffee-google sure, let's take care of the codacy recommendations. |
tcoffee-google
commented
Jun 9, 2017
Fixed for BigQuery --- I'll change this others once this one is approved. |
garrettjonesgoogle
commented
Jun 9, 2017
LGTM |
For reference in case of future maintenance, the enums to be converted were found from instances of the (Emacs-style) regexp and conversions were done by fixed-point application of the following regexp replacements (the first two are sufficient for cases without subfields):
=> (removing the initial "static" for top-level enums)
=>
=>
=> |
coveralls
commented
Jun 9, 2017
Changes Unknown when pulling f45aebd on tcoffee-google:string_enum_bigquery into ** on GoogleCloudPlatform:master**. |
coveralls
commented
Jun 9, 2017
Changes Unknown when pulling f45aebd on tcoffee-google:string_enum_bigquery into ** on GoogleCloudPlatform:master**. |
tcoffee-google
commented
Jun 9, 2017
Addresses #1944. |
🤖 I have created a release *beep* *boop* --- ## [2.37.2](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.37.1...v2.37.2) (2023-05-30) ### Bug Fixes * Pass the parameter value of enableConnectionPool instead of true always ([#2096](https://togithub.com/googleapis/java-bigquerystorage/issues/2096)) ([253678d](https://togithub.com/googleapis/java-bigquerystorage/commit/253678df630c717fbcf7018b3245aa56b5f22660)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.26.0 ([#2114](https://togithub.com/googleapis/java-bigquerystorage/issues/2114)) ([8b44534](https://togithub.com/googleapis/java-bigquerystorage/commit/8b4453476b17dcbb10faaa52c6a2b06506d89d62)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.26.1 ([#2128](https://togithub.com/googleapis/java-bigquerystorage/issues/2128)) ([62afd46](https://togithub.com/googleapis/java-bigquerystorage/commit/62afd46bb4cad09886c49bac88a2052c8754f8fe)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.10.1 ([#2121](https://togithub.com/googleapis/java-bigquerystorage/issues/2121)) ([3fabc5d](https://togithub.com/googleapis/java-bigquerystorage/commit/3fabc5d467becd3d9b816f9545e8a1e6dd09f682)) * Update dependency com.google.http-client:google-http-client to v1.43.2 ([#2109](https://togithub.com/googleapis/java-bigquerystorage/issues/2109)) ([0d57daf](https://togithub.com/googleapis/java-bigquerystorage/commit/0d57daff0d113089ba1957753febeed92024e4c2)) * Update dependency com.google.truth:truth to v1.1.4 ([#2126](https://togithub.com/googleapis/java-bigquerystorage/issues/2126)) ([a0be7ad](https://togithub.com/googleapis/java-bigquerystorage/commit/a0be7ad59b1604972b190befe2e4befd2e2c6431)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Add an explicit check to the test whether there are credentials available.
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Introduces generalization of pattern for Storage/Datastore/Logging to simulate enum types with
single data members. This appears to cover all cases in remaining Cloud APIs.