Uh oh!
There was an error while loading. Please reload this page.
Retry in more situations - #2239
Conversation
googlebot
commented
Jul 14, 2017
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Change the code to retry in more situations (when copying or deleting files, checking file permissions, or reading file size). Also give a comprehensive exception message when we run out of retries, to make it abundantly clear that retries were attempted. Those aggressive retries only happen if the user has set the MaxChannelReopens option. If unset, we still get the nicer error message but they'll say something like "All 0 reopens failed." Note that this doesn't affect the normal retries done at a lower level by the cloud.storage.Storage object.
e53e488 to
781d82cComparegooglebot
commented
Jul 14, 2017
CLAs look good, thanks! |
droazen
left a comment
There was a problem hiding this comment.
Two comments to address (including one major issue in CloudStorageFileSystemProvider.copy()), otherwise looks good!
We've been running at scale with a variant of this patch, and have found that it completely clears up the intermittent 503/SSL errors when accessing GCS via google-cloud-nio that have been plaguing us for so long!
| if (!setContentDisposition) { | ||
| tgtInfoBuilder.setContentDisposition(blobInfo.getContentDisposition()); | ||
| CopyWriter copyWriter = storage.copy(copyReqBuilder.build()); | ||
| copyWriter.getResult(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
| public void handleRetryForStorageException(final StorageException exs) throws StorageException { | ||
| if (!isRetryable(exs)) { | ||
| throw exs; | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
droazen
commented
Jul 27, 2017
Replaced by #2281, which addresses the issues raised above (@jean-philippe-martin is away for a month, which is why we chose to open a new PR). This can be closed. |
jean-philippe-martin
commented
Aug 21, 2017
closing, we should merge #2281 instead. |
…#2239) * chore: Update generation configuration at Thu Sep 25 02:29:21 UTC 2025 * chore: Update generation configuration at Sat Sep 27 02:24:05 UTC 2025 * chore: Update generation configuration at Tue Sep 30 02:25:54 UTC 2025 * chore: generate libraries at Tue Sep 30 02:26:32 UTC 2025 * chore: Update generation configuration at Wed Oct 1 02:31:59 UTC 2025 * chore: Update generation configuration at Thu Oct 2 02:27:17 UTC 2025 * chore: Update generation configuration at Fri Oct 3 02:26:42 UTC 2025 * chore: generate libraries at Fri Oct 3 02:27:20 UTC 2025 * chore: Update generation configuration at Sat Oct 4 02:24:31 UTC 2025
* fix: retry INTERNAL retriable auth errors Change-Id: I3939a89d40ecd4304bccaf0340fe169d6a083712 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [2.39.3](https://togithub.com/googleapis/java-bigtable/compare/v2.39.2...v2.39.3) (2024-05-21) ### Bug Fixes * Retry INTERNAL retriable auth errors ([googleapis#2239](https://togithub.com/googleapis/java-bigtable/issues/2239)) ([d350433](https://togithub.com/googleapis/java-bigtable/commit/d350433e03c38393e9a4e89ee3cec70409a947ea)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Change the code to retry in more situations (when copying or deleting files, checking file permissions, or reading file size). Also give a comprehensive exception message when we run out of retries, to make it abundantly clear that retries were attempted.
Those aggressive retries only happen if the user has set the
MaxChannelReopensoption. If unset, we still get the nicer error message but they'll say something like "All 0 reopens failed."Note that this doesn't affect the normal retries done at a lower level by the
cloud.storage.Storageobject.