Skip to content

Add missing fields to LogEntry - #2313

Merged
saicheems merged 5 commits into
googleapis:masterfrom
saicheems:sl
Aug 9, 2017
Merged

Add missing fields to LogEntry#2313
saicheems merged 5 commits into
googleapis:masterfrom
saicheems:sl

Conversation

@saicheems

@saicheemssaicheems commented Aug 7, 2017•
edited
Loading

Copy link
Copy Markdown

Resolves#2201

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2017
@saicheems

saicheems commented Aug 7, 2017

Copy link
Copy Markdown
Author

Note, I'm missing doc strings -- I'll add those in, but I'm looking for some direction on how to write them.

@saicheems

saicheems commented Aug 7, 2017

Copy link
Copy Markdown
Author

Especially for fields which are "Output Only", as receiveTimestamp is.

@googleapisgoogleapis deleted a comment Aug 7, 2017
@googleapisgoogleapis deleted a comment Aug 7, 2017
@googleapisgoogleapis deleted a comment Aug 7, 2017
@googleapisgoogleapis deleted a comment Aug 7, 2017
@saicheems

saicheems commented Aug 8, 2017

Copy link
Copy Markdown
Author

Added the docstrings in, I just ripped them from the proto essentially. Lmk what else I need.

vam-google
vam-google approved these changes Aug 9, 2017
View reviewed changes

@vam-googlevam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor comments. Please address them before pushing.

Comment threadgoogle-cloud-logging/src/main/java/com/google/cloud/logging/SourceLocation.java Outdated

private static final long serialVersionUID = 8502955858162387374L;

String file;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java
}


/**

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java
builder.setTimestamp(millis);
}
}
if (entryPb.hasReceiveTimestamp()) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-logging/src/main/java/com/google/cloud/logging/LogEntry.java
tsBuilder.setNanos((int) (timestamp % MILLIS_PER_SECOND * NANOS_PER_MILLISECOND));
builder.setTimestamp(tsBuilder.build());
}
if (receiveTimestamp != null) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-logging/src/main/java/com/google/cloud/logging/SourceLocation.java
return new Builder(this);
}

LogEntrySourceLocation toPb() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-logging/src/test/java/com/google/cloud/logging/SourceLocationTest.java
public class SourceLocationTest {

private static final String FILE = "file";
private static final Long LINE = 42L;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@saicheems
saicheems merged commit be90339 into googleapis:masterAug 9, 2017
@saicheems
saicheems deleted the sl branch August 9, 2017 16:42
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-bigquery to v2.…
1e1b60c
…34.2 (#2313)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-spanner-bom to …
bc371a8
…v6.104.0 (googleapis#2313)
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@release-please
chore(main): release 2.34.1 (googleapis#2305)
3d96a26
🤖 I have created a release *beep* *boop*
---
## [2.34.1](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.34.0...v2.34.1) (2025-12-16)
### Bug Fixes
* Cast double Inf and NaN to float ([googleapis#2304](https://togithub.com/googleapis/java-spanner-jdbc/issues/2304)) ([58d0670](https://togithub.com/googleapis/java-spanner-jdbc/commit/58d067076d16f50573e53991e25fc5f3935d2a19)), closes [googleapis#2256](https://togithub.com/googleapis/java-spanner-jdbc/issues/2256)
### Dependencies
* Update actions/checkout action to v6 ([googleapis#2299](https://togithub.com/googleapis/java-spanner-jdbc/issues/2299)) ([b89fbc8](https://togithub.com/googleapis/java-spanner-jdbc/commit/b89fbc804a8b675e47ecdc566ee49df3427beb19))
* Update dependency com.google.cloud:google-cloud-spanner to v6.104.0 ([googleapis#2312](https://togithub.com/googleapis/java-spanner-jdbc/issues/2312)) ([3f81243](https://togithub.com/googleapis/java-spanner-jdbc/commit/3f812434cddebdabbf8403807ad284fa40eeee25))
* Update dependency com.google.cloud:google-cloud-spanner to v6.105.0 ([googleapis#2325](https://togithub.com/googleapis/java-spanner-jdbc/issues/2325)) ([6b97652](https://togithub.com/googleapis/java-spanner-jdbc/commit/6b97652432c42887241a94e649331d77c8dccfbc))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.104.0 ([googleapis#2313](https://togithub.com/googleapis/java-spanner-jdbc/issues/2313)) ([bc371a8](https://togithub.com/googleapis/java-spanner-jdbc/commit/bc371a893801853723ab0c12245d69638044c733))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.105.0 ([googleapis#2326](https://togithub.com/googleapis/java-spanner-jdbc/issues/2326)) ([3122d1c](https://togithub.com/googleapis/java-spanner-jdbc/commit/3122d1c2c758cfa7565ba4a937f27fcfe4589863))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.54.2 ([googleapis#2322](https://togithub.com/googleapis/java-spanner-jdbc/issues/2322)) ([37ce0f7](https://togithub.com/googleapis/java-spanner-jdbc/commit/37ce0f72d5bc38461b2002ec2a26311d92b7dc8c))
* Update dependency io.opentelemetry:opentelemetry-bom to v1.57.0 ([googleapis#2316](https://togithub.com/googleapis/java-spanner-jdbc/issues/2316)) ([6e41a1e](https://togithub.com/googleapis/java-spanner-jdbc/commit/6e41a1ec3a422a0f76fd864a15163a18fb9d03c3))
* Update dependency net.bytebuddy:byte-buddy to v1.18.2 ([googleapis#2306](https://togithub.com/googleapis/java-spanner-jdbc/issues/2306)) ([28b47ed](https://togithub.com/googleapis/java-spanner-jdbc/commit/28b47edec46a220ccb1b5759c58d152c94271156))
* Update dependency net.bytebuddy:byte-buddy-agent to v1.18.2 ([googleapis#2307](https://togithub.com/googleapis/java-spanner-jdbc/issues/2307)) ([ba29e83](https://togithub.com/googleapis/java-spanner-jdbc/commit/ba29e835248385bb5a7ad2ceec12eca8cdd7792d))
* Update dependency org.springframework.boot:spring-boot to v4 ([googleapis#2300](https://togithub.com/googleapis/java-spanner-jdbc/issues/2300)) ([beba91c](https://togithub.com/googleapis/java-spanner-jdbc/commit/beba91c5efc89362aa1f3f9418b17e744c90b6cf))
* Update dependency org.springframework.boot:spring-boot-starter-data-jdbc to v4 ([googleapis#2301](https://togithub.com/googleapis/java-spanner-jdbc/issues/2301)) ([1d0b5d4](https://togithub.com/googleapis/java-spanner-jdbc/commit/1d0b5d40cc41d903cad3c1c63c473b86143665a3))
* Update dependency org.springframework.boot:spring-boot-starter-parent to v3.5.8 ([googleapis#2298](https://togithub.com/googleapis/java-spanner-jdbc/issues/2298)) ([5a9c025](https://togithub.com/googleapis/java-spanner-jdbc/commit/5a9c025fae0904ec4870c1db5b0dc4cfb63b08fc))
* Update dependency org.testcontainers:testcontainers to v2.0.3 ([googleapis#2323](https://togithub.com/googleapis/java-spanner-jdbc/issues/2323)) ([aaa6683](https://togithub.com/googleapis/java-spanner-jdbc/commit/aaa6683885736214612949445934b6de499667b1))
* Update dependency org.testcontainers:testcontainers-bom to v2.0.3 ([googleapis#2324](https://togithub.com/googleapis/java-spanner-jdbc/issues/2324)) ([92dc391](https://togithub.com/googleapis/java-spanner-jdbc/commit/92dc39111a365d56969d5cad7856f8a867c8968b))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot
deps: update dependency org.assertj:assertj-core to v3.27.3 (#2313)
5e80b57
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot
deps: update dependency org.assertj:assertj-core to v3.27.3 (#2313)
42cf8ee
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@DerekLeeCSDerek Lee
feat: Add APIs to enable hot backups (googleapis#2313)
93020e5
Co-authored-by: Derek Lee <derekleecs@google.com>
benjaminp pushed a commit to benjaminp/google-cloud-java that referenced this pull request Jul 13, 2026
@release-please
chore(main): release 2.44.0 (googleapis#2338)
cb0bcea
🤖 I have created a release *beep* *boop*
---
## [2.44.0](https://togithub.com/googleapis/java-bigtable/compare/v2.43.0...v2.44.0) (2024-09-16)
### Features
* Add APIs to enable hot backups ([googleapis#2313](https://togithub.com/googleapis/java-bigtable/issues/2313)) ([93020e5](https://togithub.com/googleapis/java-bigtable/commit/93020e5ae4898f8e453e269b1beddad0772b4c5b))
* Add support for awaiting Data Boost ([googleapis#2329](https://togithub.com/googleapis/java-bigtable/issues/2329)) ([60ab7a1](https://togithub.com/googleapis/java-bigtable/commit/60ab7a1a9751fcfd1c0bfc7ca1de3a35953877eb))
### Dependencies
* Update shared dependencies ([googleapis#2337](https://togithub.com/googleapis/java-bigtable/issues/2337)) ([417f800](https://togithub.com/googleapis/java-bigtable/commit/417f800b54b699e55741a7605d3ac11396eca059))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vam-googlevam-googlevam-google approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@garrettjonesgooglegarrettjonesgoogle

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@saicheems@vam-google@googlebot@garrettjonesgoogle