Uh oh!
There was an error while loading. Please reload this page.
Using the pageable response from ListCollectionIds - #2530
Merged
jabubake merged 4 commits intoOct 19, 2017
Conversation
schmidt-sebastianforce-pushed
the
mrschmidt-pagedcollections
branch
from
October 16, 2017 23:47
c2b0f8a to
33fee03Comparepongad
commented
Oct 16, 2017
Contributor
LGTM; I'll let Garrrett +2 |
This is a breaking API change, but it allows us to use a Java iterator to fetch all collection IDs. Right now, the total number of IDs are capped at 20.
schmidt-sebastianforce-pushed
the
mrschmidt-pagedcollections
branch
from
October 17, 2017 00:00
33fee03 to
4c2b8c3Compare
garrettjonesgoogle
left a comment
Contributor
There was a problem hiding this comment.
It looks like the ListCollectionIdsPagedResponse class has a private constructor. I think this case means we should change our code generation to make it accessible.
| */ | ||
| @Nonnull | ||
| ApiFuture<List<CollectionReference>> getCollections(); | ||
| Iterable<CollectionReference> getCollections() throws ExecutionException, InterruptedException; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
schmidt-sebastianforce-pushed
the
mrschmidt-pagedcollections
branch
from
October 17, 2017 23:39
6147a15 to
4582509Compareschmidt-sebastianforce-pushed
the
mrschmidt-pagedcollections
branch
3 times, most recently
from
October 19, 2017 00:39
a19b923 to
5a3d707Compareschmidt-sebastianforce-pushed
the
mrschmidt-pagedcollections
branch
from
October 19, 2017 00:48
5a3d707 to
a09224bCompareschmidt-sebastian
commented
Oct 19, 2017
ContributorAuthor
Feedback addressed. FirestoreException now inherits from BaseGrpcServiceException. |
garrettjonesgoogle
commented
Oct 19, 2017
Contributor
LGTM |
jabubake
commented
Oct 19, 2017
Contributor
Merged for @schmidt-sebastian |
schmidt-sebastian added a commit
to FirebasePrivate/google-cloud-java
that referenced
this pull request
Nov 9, 2017
chingor13 pushed a commit
that referenced
this pull request
Feb 20, 2026
* deps: update actions/checkout digest to 692973e * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
chingor13 pushed a commit
that referenced
this pull request
Mar 24, 2026
… to v2.26.1 (#2530) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.errorprone:error_prone_annotations](https://errorprone.info) ([source](https://togithub.com/google/error-prone)) | `2.24.1` -> `2.26.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>google/error-prone (com.google.errorprone:error_prone_annotations)</summary> ### [`v2.26.1`](https://togithub.com/google/error-prone/releases/tag/v2.26.1): Error Prone 2.26.1 [Compare Source](https://togithub.com/google/error-prone/compare/v2.26.0...v2.26.1) Changes: - Fix the module name of the annotations artifact: `com.google.errorprone.annotations` (google/error-prone@9d99ee7) Full Changelog: google/error-prone@v2.26.0...v2.26.1 ### [`v2.26.0`](https://togithub.com/google/error-prone/releases/tag/v2.26.0): Error Prone 2.26.0 [Compare Source](https://togithub.com/google/error-prone/compare/v2.25.0...v2.26.0) Changes: - The 'annotations' artifact now includes a `module-info.java` for Java Platform Module System support, thanks to [@​sgammon](https://togithub.com/sgammon) in [#​4311](https://togithub.com/google/error-prone/issues/4311). - Disabled checks passed to `-XepPatchChecks` are now ignored, instead of causing a crash. Thanks to [@​oxkitsune](https://togithub.com/oxkitsune) in [#​4028](https://togithub.com/google/error-prone/issues/4028). New checks: - [`SystemConsoleNull`](https://errorprone.info/bugpattern/SystemConsoleNull): Null-checking `System.console()` is not a reliable way to detect if the console is connected to a terminal. - [`EnumOrdinal`](https://errorprone.info/bugpattern/EnumOrdinal): Discourage uses of `Enum.ordinal()` Closed issues: [#​2649](https://togithub.com/google/error-prone/issues/2649), [#​3908](https://togithub.com/google/error-prone/issues/3908), [#​4028](https://togithub.com/google/error-prone/issues/4028), [#​4311](https://togithub.com/google/error-prone/issues/4311), [#​4314](https://togithub.com/google/error-prone/issues/4314) Full Changelog: google/error-prone@v2.25.0...v2.26.0 ### [`v2.25.0`](https://togithub.com/google/error-prone/releases/tag/v2.25.0): Error Prone 2.25.0 [Compare Source](https://togithub.com/google/error-prone/compare/v2.24.1...v2.25.0) New checks: - [`JUnitIncompatibleType`](https://errorprone.info/bugpattern/JUnitIncompatibleType): Detects incompatible types passed to an assertion, similar to [` TruthIncompatibleType `](https://errorprone.info/bugpattern/TruthIncompatibleType) - [`RedundantSetterCall`](https://errorprone.info/bugpattern/RedundantSetterCall): Detects fields set twice in the same chained expression. Generalization of previous `ProtoRedundantSet` check to also handle [AutoValue](https://togithub.com/google/auto/blob/main/value/userguide/index.md). Closed issues: [#​4195](https://togithub.com/google/error-prone/issues/4195), [#​4224](https://togithub.com/google/error-prone/issues/4224), [#​4228](https://togithub.com/google/error-prone/issues/4228), [#​4248](https://togithub.com/google/error-prone/issues/4248), [#​4249](https://togithub.com/google/error-prone/issues/4249), [#​4251](https://togithub.com/google/error-prone/issues/4251) Full Changelog: google/error-prone@v2.24.1...v2.25.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjAuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
chingor13 pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.38.0</summary> ## [2.38.0](googleapis/sdk-platform-java@v2.37.0...v2.38.0) (2024-03-15) ### Features * [common-protos] add `api_version` extension to `ServiceOptions`, for collaborative versioning ([95fd22c](googleapis/sdk-platform-java@95fd22c)) * [common-protos] add `api_version` extension to `ServiceOptions`, for collaborative versioning ([#2551](googleapis/sdk-platform-java#2551)) ([95fd22c](googleapis/sdk-platform-java@95fd22c)) * add `ErrorReason.LOCATION_POLICY_VIOLATED` enum value ([95fd22c](googleapis/sdk-platform-java@95fd22c)) * add `ErrorReason.LOCATION_POLICY_VIOLATED` enum value ([95fd22c](googleapis/sdk-platform-java@95fd22c)) * add `Publishing.rest_reference_documentation_uri` to aid client library publication ([95fd22c](googleapis/sdk-platform-java@95fd22c)) * add `Publishing.rest_reference_documentation_uri` to aid client library publication ([95fd22c](googleapis/sdk-platform-java@95fd22c)) * Add shopping and chat common protos. ([#2553](googleapis/sdk-platform-java#2553)) ([14769d3](googleapis/sdk-platform-java@14769d3)), closes [#2018](googleapis/sdk-platform-java#2018) * get PR description from googleapis commits ([#2531](googleapis/sdk-platform-java#2531)) ([d26580c](googleapis/sdk-platform-java@d26580c)) * Introduce OpenTelemetry Metrics Recording ([#2500](googleapis/sdk-platform-java#2500)) ([27c3a20](googleapis/sdk-platform-java@27c3a20)) * skip build only commit ([#2555](googleapis/sdk-platform-java#2555)) ([002790e](googleapis/sdk-platform-java@002790e)) * Universe Domain Environment Variable Support ([#2485](googleapis/sdk-platform-java#2485)) ([b2b0414](googleapis/sdk-platform-java@b2b0414)) ### Dependencies * normalize dependencies ([#2574](googleapis/sdk-platform-java#2574)) ([bd10d40](googleapis/sdk-platform-java@bd10d40)) * update arrow.version to v15.0.1 ([#2565](googleapis/sdk-platform-java#2565)) ([a652d47](googleapis/sdk-platform-java@a652d47)) * update dependency com.fasterxml.jackson:jackson-bom to v2.17.0 ([#2564](googleapis/sdk-platform-java#2564)) ([f099a56](googleapis/sdk-platform-java@f099a56)) * update dependency com.google.api-client:google-api-client-bom to v2.4.0 ([#2570](googleapis/sdk-platform-java#2570)) ([720a917](googleapis/sdk-platform-java@720a917)) * update dependency com.google.errorprone:error_prone_annotations to v2.26.1 ([#2530](googleapis/sdk-platform-java#2530)) ([545dfa1](googleapis/sdk-platform-java@545dfa1)) * update dependency com.google.errorprone:error_prone_annotations to v2.26.1 ([#2532](googleapis/sdk-platform-java#2532)) ([8861143](googleapis/sdk-platform-java@8861143)) * update dependency io.netty:netty-tcnative-boringssl-static to v2.0.65.final ([#2547](googleapis/sdk-platform-java#2547)) ([b516f3c](googleapis/sdk-platform-java@b516f3c)) * update dependency net.bytebuddy:byte-buddy to v1.14.12 ([#2522](googleapis/sdk-platform-java#2522)) ([60b5626](googleapis/sdk-platform-java@60b5626)) * update google api dependencies ([#2484](googleapis/sdk-platform-java#2484)) ([3ed98b1](googleapis/sdk-platform-java@3ed98b1)) * update google api dependencies ([#2538](googleapis/sdk-platform-java#2538)) ([7f5f925](googleapis/sdk-platform-java@7f5f925)) * update googleapis/java-cloud-bom digest to 3f93d58 ([#2499](googleapis/sdk-platform-java#2499)) ([d557d96](googleapis/sdk-platform-java@d557d96)) * update googleapis/java-cloud-bom digest to 659764f ([#2545](googleapis/sdk-platform-java#2545)) ([144e461](googleapis/sdk-platform-java@144e461)) * update netty dependencies ([#2480](googleapis/sdk-platform-java#2480)) ([d43592b](googleapis/sdk-platform-java@d43592b)) * update opentelemetry-java monorepo to v1.35.0 ([#2477](googleapis/sdk-platform-java#2477)) ([e34028f](googleapis/sdk-platform-java@e34028f)) * update opentelemetry-java monorepo to v1.36.0 ([#2550](googleapis/sdk-platform-java#2550)) ([31737f2](googleapis/sdk-platform-java@31737f2)) * update opentelemetry-java monorepo to v1.36.0 ([#2573](googleapis/sdk-platform-java#2573)) ([4653e2c](googleapis/sdk-platform-java@4653e2c)) * update slf4j monorepo to v2.0.12 ([#2481](googleapis/sdk-platform-java#2481)) ([29332ce](googleapis/sdk-platform-java@29332ce)) ### Documentation * minor tweaks to various comments ([95fd22c](googleapis/sdk-platform-java@95fd22c)) * minor tweaks to various comments ([95fd22c](googleapis/sdk-platform-java@95fd22c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking API change, but it allows us to use a Java iterator to fetch all collection IDs. Right now, the total number of IDs is capped at 20.
I removed the unit tests since I am unable to figure out how to build a ListCollectionIdsPagedResponse :/ Let me know if you have a suggestion.