Skip to content

Pubsub notifications - #2571

Merged
andreamlin merged 41 commits into
googleapis:masterfrom
andreamlin:pubsub_notifications
Nov 21, 2017
Merged

Pubsub notifications#2571
andreamlin merged 41 commits into
googleapis:masterfrom
andreamlin:pubsub_notifications

Conversation

@andreamlin

@andreamlinandreamlin commented Nov 2, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Expose Storage methods

  • storage.notifications.delete
  • storage.notifications.list
  • storage.notifications.insert
  • storage.projects.serviceAccounts.get

Introduce a new google-cloud-notification module that depends on

  • google-cloud-storage for all the RPC methods
  • google-cloud-pubsub for testing (a notification must be set on a Topic, which is exposed in Pubsub API) and for TopicName, which makes it easy for a user to correctly format the topic

@andreamlin
initial work for Notifications in Storage surface
2d13c45
@andreamlin
update nio FakeStorageRpc with@OverRidemethods
1b03ea7
@andreamlin
completed implementation of Notification methods
1126650
@andreamlin
added NotificationTest
d1506ad
@andreamlin
adding new Notification module
56c2f8c
@andreamlin
null check
bf7c508
@andreamlin
moving notification test from Storage to Notification module
ec6aa58
@andreamlin
Merge branch 'master' into pubsub_notifications
dd42687
@andreamlin
add serialVersionUID to NotificationInfo
946c48e
@andreamlin
moving Notification files to new module
9f90b6d
@andreamlin
moving notification methods from Storage to Notification
08162e8
@andreamlin
moving notification methods from Storage to Notification
a06c8bf
@andreamlin
public-ing some Storage methods for use by Notification
4e83f66
@andreamlin
remove NotificationOptions
2144677
@andreamlin
fixed pom.xml for Notification dependencies on latest versions of Pub…
7ead27b
…sub and Storage
@andreamlin
use TopicName instead of String topic for NotificationInfo
69d0bf8
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2017
@andreamlin
andreamlin removed the request for review from garrettjonesgoogleNovember 2, 2017 00:13
@andreamlin

andreamlin commented Nov 2, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

PTAL

@andreamlin
andreamlin removed the request for review from vam-googleNovember 6, 2017 19:11
@andreamlin

andreamlin commented Nov 9, 2017

Copy link
Copy Markdown
ContributorAuthor

Addressed all comments. PTAL

@pongad

pongad commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

Responded to your question about AutoValue.
Apart from that and Garrett's concern about relationship with storage, LGTM.

@pongad

pongad commented Nov 17, 2017

Copy link
Copy Markdown
Contributor

Hmm, that's strange. If you want to submit this as is. It's fine. Easy to convert later if we feel like it.

Please add a todo to investigate AutoValue, but LGTM.

@andreamlin

andreamlin commented Nov 17, 2017

Copy link
Copy Markdown
ContributorAuthor

PTAL

garrettjonesgoogle
garrettjonesgoogle reviewed Nov 21, 2017
View reviewed changes
Comment threadgoogle-cloud-notification/README.md Outdated
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-notification</artifactId>
<version>0.26.1-alpha</version>

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-notification/pom.xml Outdated
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>google-cloud-storage</artifactId>
<version>${storage.version}</version>

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-notification/src/main/java/com/google/cloud/notification/NotificationInfo.java Outdated
objectNamePrefix = builder.objectNamePrefix;
}

// TODO(andrealin): method comments for the getters.

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-storage/src/main/java/com/google/cloud/storage/StorageOptions.java Outdated
}

protected StorageRpc getStorageRpcV1() {
public StorageRpc getStorageRpcV1() {

This comment was marked as spam.

Sign in to view

@andreamlin

andreamlin commented Nov 21, 2017

Copy link
Copy Markdown
ContributorAuthor

@garrettjonesgoogle PTAL

garrettjonesgoogle
garrettjonesgoogle approved these changes Nov 21, 2017
View reviewed changes

@garrettjonesgooglegarrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin
andreamlin merged commit 40b0da8 into googleapis:masterNov 21, 2017
@andreamlin
andreamlin deleted the pubsub_notifications branch February 27, 2018 18:07
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-bigquery…
54774f9
…storage to v3.7.0 (#2571)
suztomo pushed a commit that referenced this pull request Mar 30, 2026
@andreamlin
Pubsub notifications (#2571)
e73c65e
Expose Storage methods
- storage.notifications.delete
- storage.notifications.list
- storage.notifications.insert
- storage.projects.serviceAccounts.get
Introduce a new google-cloud-notification module that depends on
- google-cloud-storage for all the RPC methods
- google-cloud-pubsub for testing (a notification must be set on a Topic, which is exposed in Pubsub API) and for TopicName, which makes it easy for a user to correctly format the topic
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot@gcf-owl-bot
deps: update dependency com.google.cloud:sdk-platform-java-config to …
471f4e4
…v3.31.0 (#2571)
* deps: update dependency com.google.cloud:sdk-platform-java-config to v3.31.0
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Apr 1, 2026
@andreamlin
Pubsub notifications (#2571)
58b3470
Expose Storage methods
- storage.notifications.delete
- storage.notifications.list
- storage.notifications.insert
- storage.projects.serviceAccounts.get
Introduce a new google-cloud-notification module that depends on
- google-cloud-storage for all the RPC methods
- google-cloud-pubsub for testing (a notification must be set on a Topic, which is exposed in Pubsub API) and for TopicName, which makes it easy for a user to correctly format the topic
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-core to v2.60.3 (…
ac2c85a
…#2571)
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
@release-please
chore(main): release 1.142.0 (#2575)
73f6c42
🤖 I have created a release *beep* *boop*
---
## [1.142.0](https://togithub.com/googleapis/java-pubsub/compare/v1.141.5...v1.142.0) (2025-10-07)
### Features
* Support the protocol version in StreamingPullRequest ([af40810](https://togithub.com/googleapis/java-pubsub/commit/af40810ea0668ce4e8c4d69bdbb4b281073976d0))
### Bug Fixes
* **deps:** Update the Java code generator (gapic-generator-java) to 2.62.3 ([af40810](https://togithub.com/googleapis/java-pubsub/commit/af40810ea0668ce4e8c4d69bdbb4b281073976d0))
### Dependencies
* Update actions/checkout action to v5 ([#2562](https://togithub.com/googleapis/java-pubsub/issues/2562)) ([b7fa499](https://togithub.com/googleapis/java-pubsub/commit/b7fa49968e85dfeba8a84ea29f8ddf9d33ef22c5))
* Update actions/checkout action to v5 ([#2573](https://togithub.com/googleapis/java-pubsub/issues/2573)) ([4153dba](https://togithub.com/googleapis/java-pubsub/commit/4153dbacb386b130780c8d1e5596e3502af8e32b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.55.1 ([#2566](https://togithub.com/googleapis/java-pubsub/issues/2566)) ([66c9ec4](https://togithub.com/googleapis/java-pubsub/commit/66c9ec4a26b76ca384dce71a8ab6bce8cd34b8a3))
* Update dependency com.google.cloud:google-cloud-core to v2.60.2 ([#2557](https://togithub.com/googleapis/java-pubsub/issues/2557)) ([460bcd9](https://togithub.com/googleapis/java-pubsub/commit/460bcd9158e7058f710f43200b7b7737eb47839c))
* Update dependency com.google.cloud:google-cloud-core to v2.60.3 ([#2571](https://togithub.com/googleapis/java-pubsub/issues/2571)) ([ac2c85a](https://togithub.com/googleapis/java-pubsub/commit/ac2c85ad62525aee236af54f6b5c9b1eacf4d22a))
* Update dependency com.google.cloud:google-cloud-storage to v2.58.0 ([#2561](https://togithub.com/googleapis/java-pubsub/issues/2561)) ([0189388](https://togithub.com/googleapis/java-pubsub/commit/0189388edb4d618d65f33718922ca1b11f71cb15))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.52.3 ([#2572](https://togithub.com/googleapis/java-pubsub/issues/2572)) ([0785ee4](https://togithub.com/googleapis/java-pubsub/commit/0785ee490e858c104c420046e0098d81154ae273))
* Update dependency org.assertj:assertj-core to v3.27.6 ([#2560](https://togithub.com/googleapis/java-pubsub/issues/2560)) ([c82766a](https://togithub.com/googleapis/java-pubsub/commit/c82766a9efb2bb4df01fb7fdcb35259db39e05c7))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request May 1, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-core to v2.60.3 (…
12f0d51
…#2571)
meltsufin pushed a commit that referenced this pull request May 1, 2026
@release-please
chore(main): release 1.142.0 (#2575)
b2a81a3
🤖 I have created a release *beep* *boop*
---
## [1.142.0](https://togithub.com/googleapis/java-pubsub/compare/v1.141.5...v1.142.0) (2025-10-07)
### Features
* Support the protocol version in StreamingPullRequest ([648cbb8](https://togithub.com/googleapis/java-pubsub/commit/648cbb8c912be347f09a6ec30288c083103762a9))
### Bug Fixes
* **deps:** Update the Java code generator (gapic-generator-java) to 2.62.3 ([648cbb8](https://togithub.com/googleapis/java-pubsub/commit/648cbb8c912be347f09a6ec30288c083103762a9))
### Dependencies
* Update actions/checkout action to v5 ([#2562](https://togithub.com/googleapis/java-pubsub/issues/2562)) ([aec9bee](https://togithub.com/googleapis/java-pubsub/commit/aec9bee0ea8c1440c80f62dac1f7dca3619c5356))
* Update actions/checkout action to v5 ([#2573](https://togithub.com/googleapis/java-pubsub/issues/2573)) ([7f637de](https://togithub.com/googleapis/java-pubsub/commit/7f637dee56eb5898d6d30ddd499caed2eac92b4b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.55.1 ([#2566](https://togithub.com/googleapis/java-pubsub/issues/2566)) ([07e69f8](https://togithub.com/googleapis/java-pubsub/commit/07e69f806737fbdf56323f30203deb0107938ca3))
* Update dependency com.google.cloud:google-cloud-core to v2.60.2 ([#2557](https://togithub.com/googleapis/java-pubsub/issues/2557)) ([fcbe864](https://togithub.com/googleapis/java-pubsub/commit/fcbe864453521254287e1e44835ae793e0eaa939))
* Update dependency com.google.cloud:google-cloud-core to v2.60.3 ([#2571](https://togithub.com/googleapis/java-pubsub/issues/2571)) ([12f0d51](https://togithub.com/googleapis/java-pubsub/commit/12f0d514ddd806e9ac98b09304d486d151d3a49a))
* Update dependency com.google.cloud:google-cloud-storage to v2.58.0 ([#2561](https://togithub.com/googleapis/java-pubsub/issues/2561)) ([c962a7e](https://togithub.com/googleapis/java-pubsub/commit/c962a7efa01a1c2e61eb9e9404c37f3064d6708e))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.52.3 ([#2572](https://togithub.com/googleapis/java-pubsub/issues/2572)) ([d899d3b](https://togithub.com/googleapis/java-pubsub/commit/d899d3bd39abbb13324a16cea8a1be093d69337e))
* Update dependency org.assertj:assertj-core to v3.27.6 ([#2560](https://togithub.com/googleapis/java-pubsub/issues/2560)) ([fd33477](https://togithub.com/googleapis/java-pubsub/commit/fd3347781a299fdd30ee90a4a25dc4d93e794428))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
@mutianf
fix: close otel instance (googleapis#2571)
cb17e75
* fix: close otel instance
* do not close custom otel
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
@release-please
chore(main): release 2.58.1 (googleapis#2573)
869ab29
🤖 I have created a release *beep* *boop*
---
## [2.58.1](https://togithub.com/googleapis/java-bigtable/compare/v2.58.0...v2.58.1) (2025-04-28)
### Bug Fixes
* Close otel instance ([googleapis#2571](https://togithub.com/googleapis/java-bigtable/issues/2571)) ([cb17e75](https://togithub.com/googleapis/java-bigtable/commit/cb17e75bbe4cc82d64acc6418f35f95ebcbe3d0c))
---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@pongadpongadpongad left review comments
@garrettjonesgooglegarrettjonesgooglegarrettjonesgoogle approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andreamlin@pongad@garrettjonesgoogle@googlebot