Add restartableInputStream, first commit by yihanzhen · Pull Request #2682 · googleapis/google-cloud-java

yihanzhen · 2017-12-05T00:35:54Z

PTAL -
@garrettjonesgoogle Not finished yet, just to make sure the idea aligns with #2620

garrettjonesgoogle · 2017-12-06T17:44:33Z

@vam-google , could you review this?

vam-google

Please also address all the codacy-bot comments (unused imports & stuff).

Sign in to view

@@ -0,0 +1,48 @@
+/*
+ * Copyright 2015 Google Inc. All Rights Reserved.


Sign in to view

+ throw new IOExpection();
+ }
+ }
+}


Sign in to view

+import java.io.InputStream;
+
+/**
+ *


Sign in to view

+ */
+public class RestartableInputStream {
+
+ InputStream inputStream;


Sign in to view

+ this.inputStream.mark(Integer.MAX_VALUE);
+ }
+ catch (IOException e) {
+ throw new IOExpection();


Sign in to view

+package com.google.cloud.storage;
+
+import com.google.api.client.http.AbstractInputStreamContent;
+import sun.nio.ch.IOUtil;


Sign in to view

+
+ public RestartableInputStream(InputStream inputStream) {
+ this.inputStream = inputStream;
+ this.inputStream.mark(Integer.MAX_VALUE);


Sign in to view

+ public void restart() {
+ try {
+ this.inputStream.reset();
+ this.inputStream.mark(Integer.MAX_VALUE);


Sign in to view

 }

+ @Override
+ public StorageObject create(StorageObject storageObject, final RestartableInputStream content,


Sign in to view

+import java.io.InputStream;
+import java.io.OutputStream;
+
+public final class RetryableInputStreamContent extends AbstractInputStreamContent {


garrettjonesgoogle · 2017-12-21T17:44:23Z

@hzyi-google could you address @vam-google 's comments?

yihanzhen · 2017-12-21T22:12:34Z

A lot of changes need to be made for this, so abandoning. With submit a different PR when finished.

…11.2 (#2682)

🤖 I have created a release *beep* *boop* --- <details><summary>2.40.0</summary> ## [2.40.0](googleapis/sdk-platform-java@v2.39.0...v2.40.0) (2024-05-02) ### Features * [common-protos] add `Weight` to common types for Shopping APIs to be used for accounts bundle ([#2699](googleapis/sdk-platform-java#2699)) ([90a28ef](googleapis/sdk-platform-java@90a28ef)) * add a CLI tool to validate generation configuration ([#2691](googleapis/sdk-platform-java#2691)) ([f52f8cc](googleapis/sdk-platform-java@f52f8cc)) * Parser to consume the api-versioning value from proto ([#2630](googleapis/sdk-platform-java#2630)) ([c112b37](googleapis/sdk-platform-java@c112b37)) * Update Gapic generator and Gax to emit api-versioning via header ([#2671](googleapis/sdk-platform-java#2671)) ([cb5ada0](googleapis/sdk-platform-java@cb5ada0)) ### Bug Fixes * change folder prefix for adding headers ([#2688](googleapis/sdk-platform-java#2688)) ([ab5ba1d](googleapis/sdk-platform-java@ab5ba1d)) * Log HttpJson's async thread pool core size ([#2697](googleapis/sdk-platform-java#2697)) ([31038d1](googleapis/sdk-platform-java@31038d1)) * replace `cfg = "host"` with `cfg = "exec"` ([#2637](googleapis/sdk-platform-java#2637)) ([fd12e0f](googleapis/sdk-platform-java@fd12e0f)) * Return resolved endpoint from StubSettings' Builder ([#2715](googleapis/sdk-platform-java#2715)) ([6139a73](googleapis/sdk-platform-java@6139a73)) ### Dependencies * Make opentelemetry-api an optional dependency. ([#2681](googleapis/sdk-platform-java#2681)) ([2239c8c](googleapis/sdk-platform-java@2239c8c)) * update dependency absl-py to v2.1.0 ([#2659](googleapis/sdk-platform-java#2659)) ([b2b7738](googleapis/sdk-platform-java@b2b7738)) * update dependency gitpython to v3.1.43 ([#2656](googleapis/sdk-platform-java#2656)) ([6d273ad](googleapis/sdk-platform-java@6d273ad)) * update dependency lxml to v5.2.1 ([#2661](googleapis/sdk-platform-java#2661)) ([7a34168](googleapis/sdk-platform-java@7a34168)) * update dependency net.bytebuddy:byte-buddy to v1.14.14 ([#2703](googleapis/sdk-platform-java#2703)) ([72b0441](googleapis/sdk-platform-java@72b0441)) * update dependency typing to v3.10.0.0 ([#2663](googleapis/sdk-platform-java#2663)) ([4c64e98](googleapis/sdk-platform-java@4c64e98)) * update gapic-showcase to v0.33.0 ([#2653](googleapis/sdk-platform-java#2653)) ([5c12155](googleapis/sdk-platform-java@5c12155)) ### Documentation * Add contributing guidelines to PR and issue templates ([#2682](googleapis/sdk-platform-java#2682)) ([82f5ce8](googleapis/sdk-platform-java@82f5ce8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

#2682)

…v3.56.1 (#2682) Co-authored-by: Jin Seop Kim <jinseop@google.com>

…s#2682) * textproxy: Allow testproxy to build its own proto registry Change-Id: Ie930064363d92d61daad498e8380dd87ab6722dd * testproxy: Remove manual dependency resolution from ResultSetSerializer We now require the clients to provide FileDescriptorSet with files in dependency order Change-Id: I240cfe8f4d499ba7053dfab1f119972de1810fce --------- Co-authored-by: Mattie Fu <mattiefu@google.com>

Add restartableInputStream, first commit
f1d2b00

yihanzhen requested a review from garrettjonesgoogle December 5, 2017 00:35

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2017

garrettjonesgoogle requested a review from vam-google December 6, 2017 17:44

vam-google reviewed Dec 8, 2017
View reviewed changes

garrettjonesgoogle removed their request for review December 21, 2017 17:44

yihanzhen closed this Dec 21, 2017

yihanzhen deleted the storage_restartable_input_stream branch December 21, 2017 22:12

dmitry-fa mentioned this pull request May 6, 2020
Add Storage.create() method which takes a restartable input stream googleapis/java-storage#201
Closed

chingor13 pushed a commit that referenced this pull request Feb 20, 2026
deps: update dependency org.junit.vintage:junit-vintage-engine to v5.…
8cc01e1
…11.2 (#2682)

chingor13 pushed a commit that referenced this pull request Mar 24, 2026
docs: Add contributing guidelines to PR and issue templates (#2682)
82f5ce8

chingor13 pushed a commit that referenced this pull request Mar 30, 2026
chore: Update generation configuration at Wed Aug 21 02:15:24 UTC 2024 (
241c25c
#2682)

meltsufin pushed a commit that referenced this pull request Apr 29, 2026
deps: update dependency com.google.cloud:sdk-platform-java-config to …
1a94be9
…v3.56.1 (#2682) Co-authored-by: Jin Seop Kim <jinseop@google.com>

meltsufin pushed a commit that referenced this pull request May 1, 2026
deps: update dependency com.google.cloud:sdk-platform-java-config to …
e3442ec
…v3.56.1 (#2682) Co-authored-by: Jin Seop Kim <jinseop@google.com>

		@@ -0,0 +1,48 @@
		/*
		* Copyright 2015 Google Inc. All Rights Reserved.

Uh oh!

Conversation

yihanzhen commented Dec 5, 2017

Uh oh!

garrettjonesgoogle commented Dec 6, 2017

Uh oh!

vam-google left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

garrettjonesgoogle commented Dec 21, 2017

Uh oh!

yihanzhen commented Dec 21, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants