Skip to content

bigquery: make query() return iterator - #2685

Merged
pongad merged 4 commits into
googleapis:bq-perffrom
pongad:bq-wait
Dec 12, 2017
Merged

bigquery: make query() return iterator#2685
pongad merged 4 commits into
googleapis:bq-perffrom
pongad:bq-wait

Conversation

@pongad

@pongadpongad commented Dec 7, 2017

Copy link
Copy Markdown
Contributor

This also makes queries require fewer RPCs if detailed job statuses are
not required.

If a query fails, then query() throws an exception detailing why
it fails and provides the job ID so users can retrieve more details
themselves.

Updates #2591.

@pongad
bigquery: make query() return iterator
5676a4b
This also makes queries require fewer RPCs if detailed job statuses are
not required.
If a query fails, then query() throws an exception detailing why
it fails and provides the job ID so users can retrieve more details
themselves.
Updates #2591.
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2017
@pongad
pongad requested a review from tswastDecember 7, 2017 09:04
@pongad

pongad commented Dec 7, 2017

Copy link
Copy Markdown
ContributorAuthor

I still have to fix the examples. I'll do that in a follow up commit. Putting this for review now to reduce review latency.

tswast
tswast reviewed Dec 7, 2017
View reviewed changes
Comment threadgoogle-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
public Job query(QueryJobConfiguration configuration, JobOption... options)
throws InterruptedException {
public QueryResult query(QueryJobConfiguration configuration, JobOption... options)
throws InterruptedException, JobException {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadgoogle-cloud-bigquery/src/main/java/com/google/cloud/bigquery/QueryResponse.java

abstract long getTotalRows();

abstract ImmutableList<BigQueryError> getErrors();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Dec 11, 2017

Copy link
Copy Markdown
ContributorAuthor

@tswast PTAL

@pongad
pongad merged commit 0e2e9ed into googleapis:bq-perfDec 12, 2017
@pongad
pongad deleted the bq-wait branch December 12, 2017 00:50
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot
deps: update googleapis/sdk-platform-java action to v2.47.0 (#2685)
c7c9ccd
rahul2393 pushed a commit to akash329d/google-cloud-java that referenced this pull request May 21, 2026
@kongweihan
feat: Add CSM for batch write flow control (googleapis#2685)
e29607c
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes
@garrettjonesgooglegarrettjonesgoogleAwaiting requested review from garrettjonesgoogle

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pongad@tswast@googlebot